-
Notifications
You must be signed in to change notification settings - Fork 476
[FEAT] Removed share
module from lib_ccx
#1651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Removed share
module from lib_ccx
#1651
Conversation
share
module in lib_ccxr
b94da11
to
c942503
Compare
cc385f0
to
a4d04a6
Compare
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 888ffa4...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
270bf65
to
1d8b363
Compare
share
module in lib_ccxrshare
module from lib_ccx
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 6300bb7...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
{pull request content here}
This PR migrates the sharing service used by the cctranslate service. The first draft was added on 5/1/2025. The new rust Implentation is in
/src/rust/lib_ccxr/src/share/
.Changes Made
/src/rust/lib_ccxr/src/share/share.rs
/src/rust/lib_ccxr/src/share/tests.rs
contains some preliminary tests./src/rust/src/libccxr_exports/share.rs
contains the C bindings, as per doc specification