-
Notifications
You must be signed in to change notification settings - Fork 517
[FIX] Updated preprocessor directives for macOS #1661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit cbd8e27...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Check the result page for more info. |
|
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit cbd8e27...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
|
Hi, @canihavesomecoffee @cfsmp3 |
It needs to pass the format tests before it can be merged |
|
sure |
bb02382 to
36258e8
Compare
|
Hi, @cfsmp3 Should a new PR be opened for that as it needs some |
568cc22 to
ac8a70b
Compare
|
It should pass that test too since @canihavesomecoffee and @PunitLodha solved that issue |
Please rebase |
ac8a70b to
4644a71
Compare
4644a71 to
b08c5fa
Compare
a8ad22b to
b480c8b
Compare
done |
|
Thanks @cfsmp3 |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
I tried compiling ccxr on mac and ran into a few problems
typedef Bytewas not happening in case the OS was MacOS__APPLE__and__MACH__