Skip to content

Conversation

@vatsalkeshav
Copy link
Contributor

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

This PR resolves the warning posed by depreciated module std::intrinsics by replacing the same with std::mem module

error: use of deprecated module `std::intrinsics`: import this function via `std::mem` instead
  --> src/decoder/window.rs:15:17
   |
15 |     intrinsics::copy_nonoverlapping,
   |                 ^^^^^^^^^^^^^^^^^^^
   |

@vatsalkeshav vatsalkeshav marked this pull request as ready for review February 24, 2025 06:12
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 8c90bda...:

Report Name Tests Passed
Broken 0/13
CEA-708 0/14
DVB 0/7
DVD 0/3
DVR-MS 0/2
General 0/27
Hauppage 0/3
MP4 0/3
NoCC 0/10
Options 0/86
Teletext 0/21
WTV 0/13
XDS 0/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:


Check the result page for more info.

@vatsalkeshav
Copy link
Contributor Author

@cfsmp3 @prateekmedia
could you please review this

@prateekmedia
Copy link
Member

prateekmedia commented Mar 8, 2025

Hi @Vats004, In latest rust stable (1.85.0) this is still not deprecated yet!

@vatsalkeshav
Copy link
Contributor Author

It generates a warning on compilation in both stable toolchain and nighlty toolchain

@vatsalkeshav
Copy link
Contributor Author

vatsalkeshav commented Mar 9, 2025

They say "on compilation no news is the best news"

Copy link
Member

@prateekmedia prateekmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@prateekmedia prateekmedia merged commit e597f01 into CCExtractor:master Mar 29, 2025
16 checks passed
vatsalkeshav added a commit to vatsalkeshav/ccextractor-z that referenced this pull request Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants