Skip to content

Conversation

@vatsalkeshav
Copy link
Contributor

@vatsalkeshav vatsalkeshav commented Mar 21, 2025

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

This PR migrates /src/lib_ccx/ccx_decoders_vbi.c to rust.
These changes have been made-

  1. Pure rust equivalent functions in /src/rust/lib_ccxr/src/decoder_isdb/functions_vbi_main.rs (helpers in functions_vbi_slice.rs, functions_vbi_decode.rs, vbi_service_table.rs)
  2. Required datatypes in /src/rust/lib_ccxr/src/decoder_isdb, structs_xds.rs, structs_isdb.rs, structs_ccdecode.rs, structs_vbi_slice.rs, structs_vbi_decode.rs
  3. Exit codes etc in /src/rust/lib_ccxr/src/decoder_isdb/exit_codes.rs

@vatsalkeshav vatsalkeshav changed the title [FEAT]: added vbis module in lib_ccxr [WIP]: added vbis module in lib_ccxr Mar 21, 2025
@vatsalkeshav vatsalkeshav marked this pull request as draft March 23, 2025 06:55
@cfsmp3 cfsmp3 requested a review from prateekmedia March 23, 2025 07:11
@vatsalkeshav vatsalkeshav marked this pull request as ready for review March 23, 2025 16:44
@vatsalkeshav vatsalkeshav changed the title [WIP]: added vbis module in lib_ccxr [FEAT]: added vbis module in lib_ccxr Mar 24, 2025
hrideshmg and others added 4 commits March 28, 2025 23:40
* fix: do not free ocr text before return

* fix(OCR): erode and dilate function
…#1671)

* fix unknown element for IETF tag

* added documentation changes

* added formatting for clang-format
@vatsalkeshav vatsalkeshav changed the title [FEAT]: added vbis module in lib_ccxr [WIP]: Add decoder_vbi module in lib_ccxr Mar 29, 2025
@vatsalkeshav vatsalkeshav marked this pull request as draft March 29, 2025 19:00
@vatsalkeshav vatsalkeshav changed the title [WIP]: Add decoder_vbi module in lib_ccxr [WIP]: Add module decoder_vbi in lib_ccxr Apr 12, 2025
@vatsalkeshav vatsalkeshav changed the title [WIP]: Add module decoder_vbi in lib_ccxr [WIP][FEAT]: Add module decoder_vbi in lib_ccxr Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants