Skip to content

Conversation

@vatsalkeshav
Copy link
Contributor

@vatsalkeshav vatsalkeshav commented Apr 10, 2025

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Recently updated to [email protected] on M1 Mac and CCExtractor compilation started failing for all 3 methods in src/COMPILATION.MD.
The issue was due to some update in Xcode command-line-tools which updated clang to Apple clang version 17.0.0 (clang-1700.0.13.3)
Updating these preprocessor directives in third party libs solves the issue :

  • src/thirdparty/libpng/pngpriv.h
  • src/thirdparty/zlib/zutil.h

Also updated dependencies(brew install cmake gpac) in src/docs/COMPILATION.MD

@vatsalkeshav vatsalkeshav changed the title [FIX] Updated preprocessor directives for compilation on silicon mac [FIX] Fix compilation on silicon mac Apr 10, 2025
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit b62027a...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 80/86
Teletext 21/21
WTV 13/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

@cfsmp3 cfsmp3 self-requested a review April 11, 2025 05:43
@cfsmp3 cfsmp3 merged commit 888ffa4 into CCExtractor:master Apr 11, 2025
16 of 17 checks passed
vatsalkeshav added a commit to vatsalkeshav/ccextractor-z that referenced this pull request Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants