-
Notifications
You must be signed in to change notification settings - Fork 516
[FIX] Fix compilation on silicon mac #1688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit b62027a...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
cfsmp3
approved these changes
Apr 11, 2025
vatsalkeshav
added a commit
to vatsalkeshav/ccextractor-z
that referenced
this pull request
Apr 12, 2025
….command (CCExtractor#1688) Co-authored-by: vats004 <=>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Recently updated to [email protected] on M1 Mac and CCExtractor compilation started failing for all 3 methods in src/COMPILATION.MD.
The issue was due to some update in Xcode command-line-tools which updated clang to
Apple clang version 17.0.0 (clang-1700.0.13.3)Updating these preprocessor directives in third party libs solves the issue :
Also updated dependencies(
brew install cmake gpac) in src/docs/COMPILATION.MD