Skip to content

Conversation

@VarshaSree07
Copy link

  • [✅ ] I have read and understood the contributors guide.
  • [✅ ] I have checked that another pull request for this purpose does not exist.
  • [✅ ] I have considered, and confirmed that this submission will be valuable to others.
  • [✅ ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [✅ ] I give this submission freely, and claim no ownership to its content.
  • [✅ ] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • [ ✅] I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Hi! I’m reopening this PR since the previous one (#1683) was closed without merging, but the CI tests had passed successfully. I’ve made sure that all the necessary changes are in place, and everything is up to date. Please let me know if any further changes are needed — I’m happy to update it. Thanks for your time and consideration!

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 5b327c7...:

Report Name Tests Passed
Broken 12/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 23/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 83/86
Teletext 21/21
WTV 13/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 888ffa4...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 85/86
Teletext 21/21
WTV 13/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

Copy link
Member

@canihavesomecoffee canihavesomecoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This quite seems like a bogus PR just for the sake of having one. Where is the proposed functionality?

If this is done, the old level and strategy will be applied to the data
compressed before deflateParams(), and the new level and strategy will be
applied to the the data compressed after deflateParams().
applied to the data compressed after deflateParams().
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't touch code from third party libraries, especially not to fix typos.

- Fix: CEA-708: Better timing, fixes for missing subtitles
- Fix: timing for direct rollup
- Fix: timing for VOB files with multiple chapters
- Enhanced: -out=report now lists detected Teletext subtitle pages under "Pages With Subtitles" (previously left blank even when pages were detected). Improves analysis for manual page selection use cases.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this enhancement? I see nothing else in this PR.

@prateekmedia prateekmedia marked this pull request as draft May 12, 2025 15:34
@prateekmedia
Copy link
Member

Hi @VarshaSree07, Since this PR is not ready, I will have to close this. You can reopen this when your said changes in CHANGELOG.txt are done i.e. the --out=report change.

  • Also next time please use appropriate title for the PR and use - [x] to mark a checkbox in PR description instead of pasting a check emoji .

If you want to fix typo in cc_bitstream.h that is fine, you can reopen a PR without updating CHANGELOG.txt, Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants