-
Notifications
You must be signed in to change notification settings - Fork 517
Varsha/1034 #1699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Varsha/1034 #1699
Conversation
|
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 5b327c7...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
|
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 888ffa4...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
canihavesomecoffee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This quite seems like a bogus PR just for the sake of having one. Where is the proposed functionality?
| If this is done, the old level and strategy will be applied to the data | ||
| compressed before deflateParams(), and the new level and strategy will be | ||
| applied to the the data compressed after deflateParams(). | ||
| applied to the data compressed after deflateParams(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't touch code from third party libraries, especially not to fix typos.
| - Fix: CEA-708: Better timing, fixes for missing subtitles | ||
| - Fix: timing for direct rollup | ||
| - Fix: timing for VOB files with multiple chapters | ||
| - Enhanced: -out=report now lists detected Teletext subtitle pages under "Pages With Subtitles" (previously left blank even when pages were detected). Improves analysis for manual page selection use cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this enhancement? I see nothing else in this PR.
|
Hi @VarshaSree07, Since this PR is not ready, I will have to close this. You can reopen this when your said changes in CHANGELOG.txt are done i.e. the --out=report change.
If you want to fix typo in |
My familiarity with the project is as follows (check one):
Hi! I’m reopening this PR since the previous one (#1683) was closed without merging, but the CI tests had passed successfully. I’ve made sure that all the necessary changes are in place, and everything is up to date. Please let me know if any further changes are needed — I’m happy to update it. Thanks for your time and consideration!