Skip to content

[FIX] Handle row_count decrease #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[FIX] Handle row_count decrease #1702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9144eb9
Handle row_count decrease
ewong-harmonicinc Jun 13, 2025
6ca95ec
Merge branch 'master' into master
prateekmedia Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGES.TXT
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
- Fix: Resolve compile-time error about implicit declarations (#1646)
- Fix: fatal out of memory error extracting from a VOB PS
- Fix: Unit Test Rust failing due to changes in Rust Version 1.86.0
- Fix: handle row_count decrease in CEA-708 C decoder
- Fix: Build with ENABLE_FFMPEG to support ffmpeg 5

0.94 (2021-12-14)
Expand Down
12 changes: 12 additions & 0 deletions src/lib_ccx/ccx_decoders_708.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,6 +1046,18 @@ void dtvcc_handle_DFx_DefineWindow(dtvcc_service_decoder *decoder, int window_id
if (anchor_horizontal > CCX_DTVCC_SCREENGRID_COLUMNS - col_count)
anchor_horizontal = CCX_DTVCC_SCREENGRID_COLUMNS - col_count;

if (window->is_defined)
{
if (row_count < window->row_count)
{
// Remove the oldest row if the row count is reduced
for (int i = row_count; i < window->row_count; i++)
{
dtvcc_window_rollup(decoder, window);
}
}
}

Comment on lines +1049 to +1060
Copy link
Member

@prateekmedia prateekmedia Aug 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible for you to change it to single if instead like:

if (window->is_defined && row_count <...) {
    for (...
}

window->priority = priority;
window->col_lock = col_lock;
window->row_lock = row_lock;
Expand Down
Loading