Skip to content

[FIX] escape special characters ( < > & ) to HTML context #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[FIX] escape special characters ( < > & ) to HTML context #1703

wants to merge 2 commits into from

Conversation

AlvinLi-harmonicinc
Copy link

@AlvinLi-harmonicinc AlvinLi-harmonicinc commented Jun 13, 2025 •
edited
Loading

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

The <, >, & is not suppose to be appeared in SRT, because SRT supports HTML tags.
So, the content of SRT should be treated as HTML content with those characters being escaped.
As a result, this pull request intends to do the following:

  • convert & to &amp;
  • convert < to &lt;
  • convert > to &gt;

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit a34ba0f...:
Report Name Tests Passed
Broken 10/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 0/2
General 26/27
Hauppage 2/3
MP4 3/3
NoCC 10/10
Options 26/86
Teletext 21/21
WTV 8/13
XDS 27/34

Your PR breaks these cases:

NOTE: The following tests have been failing on the master branch as well as the PR:


It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit a34ba0f...:
Report Name Tests Passed
Broken 10/13
CEA-708 14/14
DVB 2/7
DVD 3/3
DVR-MS 0/2
General 26/27
Hauppage 2/3
MP4 3/3
NoCC 10/10
Options 26/86
Teletext 7/21
WTV 7/13
XDS 27/34

Your PR breaks these cases:

NOTE: The following tests have been failing on the master branch as well as the PR:

  • ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed:

    Never

  • ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed:

    Never

  • ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2..., Last passed:

    Never

  • ccextractor --out=srt --latin1 f23a544ba8..., Last passed:

    Never

  • ccextractor --out=srt --latin1 10f0f77cf4..., Last passed:

    Test 5993

  • ccextractor --out=srt --latin1 df3b4d62d3..., Last passed:

    Never


It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvinLi-harmonicinc @ccextractor-bot @prateekmedia