Conversation
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 099fa05...:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
All tests passing on the master branch were passed completely. Check the result page for more info. |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 81fdecd...:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
All tests passing on the master branch were passed completely. Check the result page for more info. |
cfsmp3
left a comment
There was a problem hiding this comment.
Thank you for the MXF module migration! The code looks well-structured and all CI builds pass including test_rust.
However, this PR is blocked by #1711 (GXF module) which has significant issues:
- ~40 Linux test failures including crashes (exit code 139)
- ~30 Windows test failures including crashes (ACCESS_VIOLATION)
- Unresolved review comments from @prateekmedia
The sample platform test failures in this PR are likely inherited from #1711 since the GXF module is a dependency.
Next steps:
- Please work on fixing #1711 first (address the crashes and review comments)
- Once #1711 is merged, rebase this PR on master
- Re-run sample platform tests to verify MXF functionality
The MXF-specific code and your testing look good. I appreciate the screenshots showing successful subtitle extraction!
Marking as reviewed - this PR is blocked by dependency, not by its own issues.
|
Closed due to inactivity, feel free to submit a new one (make sure it's based off master) when you are ready to resume work. |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Added MXF module,


ccx_demuxer_mxf.candccx_demuxer_mxf.hTested on This sample and successfully extracting subtitles.
Dependant on #1662 and #1711
PR Moved from My Fork to Here.