Skip to content

fix: dvd regressions #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 18, 2025
Merged

fix: dvd regressions #1714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07fcb4f
fix: dvd regressions
hrideshmg Jul 17, 2025
a0c4fb5
chore: fix clippy errors
hrideshmg Aug 8, 2025
e3d2569
Merge branch 'master' into dvd_fix
hrideshmg Aug 11, 2025
ec0988b
Merge branch 'master' into dvd_fix
prateekmedia Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGES.TXT
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
1.0 (to be released)
-----------------
- Fix: Regression failures on DVD files
- Fix: Segmentation faults on MP4 files with CEA-708 captions
- Refactor: Remove API structures from ccextractor
- New: Add Encoder Module to Rust
Expand Down
2 changes: 2 additions & 0 deletions src/rust/src/libccxr_exports/bitstream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ unsafe fn copy_bitstream_c_to_rust(value: *mut bitstream) -> BitStreamRust<'stat
let i_offset = (*value)._i_pos.offset_from((*value).pos);
i_pos_in_slice = i_offset.max(0) as usize;
}
} else if (*value).pos == (*value).end {
slice = std::slice::from_raw_parts((*value).pos, 1);
}
}

Expand Down
Loading