Skip to content

Conversation

@hrideshmg
Copy link
Contributor

@hrideshmg hrideshmg commented Aug 3, 2025

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Removes the API structures from ccextractor.c. This was causing a regression due to mismatch between the options maintained by api_options and ccx_options.

Copy link
Member

@prateekmedia prateekmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prateekmedia
Copy link
Member

@hrideshmg why doesn't that one case from wtv work on windows?

@hrideshmg
Copy link
Contributor Author

@hrideshmg why doesn't that one case from wtv work on windows?

It seems to have timed out. WTV files currently take a long time to run and sometimes they hit the maximum allowed run duration. Will try to optimize them when I take an attempt at them later, its not caused by this PR at the very least.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit afde4d6...:
Report Name Tests Passed
Broken 13/13
CEA-708 13/14
DVB 7/7
DVD 0/3
DVR-MS 2/2
General 22/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 84/86
Teletext 21/21
WTV 13/13
XDS 33/34

NOTE: The following tests have been failing on the master branch as well as the PR:

  • ccextractor --service 1 --out=txt f17524b53f..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 5ae2007a79..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 1e44efd810..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 add511677c..., Last passed:

    Never

  • ccextractor --autoprogram --out=srt --latin1 e9b9008fdf..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 27e46255f0..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 1974a299f0..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc..., Last passed:

    Never

  • ccextractor --unicode c83f765c66..., Last passed:

    Never

  • ccextractor --in=ps e9b9008fdf..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 0069dffd21..., Last passed:

    Never


All tests passing on the master branch were passed completely.

Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit b63a29c...:
Report Name Tests Passed
Broken 13/13
CEA-708 13/14
DVB 2/7
DVD 0/3
DVR-MS 2/2
General 22/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 83/86
Teletext 7/21
WTV 12/13
XDS 33/34

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:

  • ccextractor --autoprogram --out=srt --latin1 1d9731bd80..., Last passed: Never
  • ccextractor --out=srt --latin1 --autoprogram 73d9313d64..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 8e8229b88b..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 7236304cfc..., Last passed: Never
  • ccextractor --out=ttxt --latin1 001dd8cdf7..., Last passed: Never
  • ccextractor --out=srt --latin1 06b3a9237d..., Last passed: Never
  • ccextractor --out=srt --latin1 83f8cceb74..., Last passed: Never
  • ccextractor --out=srt --latin1 611b4a9235..., Last passed: Never
  • ccextractor --out=srt --latin1 b46e9e8e3f..., Last passed: Never
  • ccextractor --out=srt --latin1 89e417e622..., Last passed: Never
  • ccextractor --out=srt --latin1 d59eadc4ed..., Last passed: Never
  • ccextractor --out=srt --latin1 4d4e938ef6..., Last passed: Never
  • ccextractor --out=sami --latin1 --autoprogram --no-goptime 5b4e0a6034..., Last passed: Never
  • ccextractor --service 1 --out=txt --no-bom --no-rollup ea83ff7bcb..., Last passed: Never
  • ccextractor --service 1 --out=txt da904de35d..., Last passed: Never
  • ccextractor --service 1 --out=txt 80848c45f8..., Last passed: Never
  • ccextractor --service 1 --out=txt --no-bom --no-rollup b5d6aad89f..., Last passed: Never
  • ccextractor --service 1[EUC-KR] --out=txt --no-rollup b5d6aad89f..., Last passed: Never
  • ccextractor --service 1 --out=srt da904de35d..., Last passed: Never
  • ccextractor --service 1 --out=sami da904de35d..., Last passed: Never
  • ccextractor --service 1 --out=ttxt da904de35d..., Last passed: Never
  • ccextractor --service 1[EUC-KR] b5d6aad89f..., Last passed: Never
  • ccextractor --service 1[EUC-KR] --no-rollup b5d6aad89f..., Last passed: Never
  • ccextractor --service all da904de35d..., Last passed: Never
  • ccextractor --service all[EUC-KR] b5d6aad89f..., Last passed: Never
  • ccextractor --service 1,2[UTF-8],3[EUC-KR],54 --out=txt da904de35d..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 1020459a86..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 d41b53b504..., Last passed: Never
  • ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 acf871cbfd..., Last passed: Never
  • ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 5cbb21adb6..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 9a496d3828..., Last passed: Never
  • ccextractor --out=srt --latin1 --autoprogram 56c9f34548..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 c032183ef0..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 d037c7509e..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 b22260d065..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla 7aad20907e..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla c41f73056a..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla 5d3a29f9f8..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla 70000200c0..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla 6dc772d881..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla adce82fd39..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla 15feae9133..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla 95dd33c6f1..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 01509e4d27..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla ab9cf8cfad..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 15feae9133..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 5d3a29f9f8..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 c41f73056a..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --sentencecap c032183ef0..., Last passed: Never
  • ccextractor --autoprogram --out=bin --latin1 c032183ef0..., Last passed: Never
  • ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b..., Last passed: Never
  • ccextractor --hauppauge --autoprogram --out=srt --latin1 a03b5b2a56..., Last passed: Never
  • ccextractor --autoprogram --out=srt --hauppauge --latin1 553d78e755..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --hauppauge --ucla --latin1 553d78e755..., Last passed: Never
  • ccextractor --in=mp4 --out=srt --latin1 b2771c84c2..., Last passed: Never
  • ccextractor --in=mp4 --out=srt --latin1 5df914ce77..., Last passed: Never
  • ccextractor --autoprogram --out=srt --bom --latin1 8849331dda..., Last passed: Never
  • ccextractor --mp4vidtrack --autoprogram --out=ttxt --latin1 adc0a818c3..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 08bdf0e2c1..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 bee139671a..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 3842d00925..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 80af83c038..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 837b02f722..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 41dab6b2a7..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 4b117b4d66..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 26ee6add4d..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds fca0dce412..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --output-field 1 a65d39ccb3..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --output-field 2 a65d39ccb3..., Last passed: Never
  • ccextractor --autoprogram c83f765c66..., Last passed: Never
  • ccextractor --service 1 c83f765c66..., Last passed: Never
  • ccextractor --in=ts c83f765c66..., Last passed: Never
  • ccextractor --out=srt c83f765c66..., Last passed: Never
  • ccextractor --out=sami c83f765c66..., Last passed: Never
  • ccextractor --out=dvdraw c83f765c66..., Last passed: Never
  • ccextractor --out=txt c83f765c66..., Last passed: Never
  • ccextractor --out=ttxt c83f765c66..., Last passed: Never
  • ccextractor --out=smptett c83f765c66..., Last passed: Never
  • ccextractor --goptime c83f765c66..., Last passed: Never
  • ccextractor --no-goptime c83f765c66..., Last passed: Never
  • ccextractor --fixpadding c83f765c66..., Last passed: Never
  • ccextractor --90090 c83f765c66..., Last passed: Never
  • ccextractor --myth c83f765c66..., Last passed: Never
  • ccextractor --program-number 1 c83f765c66..., Last passed: Never
  • ccextractor --datapid 256 c83f765c66..., Last passed: Never
  • ccextractor --datastreamtype 2 c83f765c66..., Last passed: Never
  • ccextractor --datastreamtype 2 --streamtype 2 c83f765c66..., Last passed: Never
  • ccextractor --no-autotimeref c83f765c66..., Last passed: Never
  • ccextractor --bom c83f765c66..., Last passed: Never
  • ccextractor --no-bom c83f765c66..., Last passed: Never
  • ccextractor --utf8 c83f765c66..., Last passed: Never
  • ccextractor --latin1 c83f765c66..., Last passed: Never
  • ccextractor --no-fontcolor c83f765c66..., Last passed: Never
  • ccextractor --no-typesetting c83f765c66..., Last passed: Never
  • ccextractor --trim c83f765c66..., Last passed: Never
  • ccextractor --sentencecap c83f765c66..., Last passed: Never
  • ccextractor --capfile /repository/Dictionary/MattS_dictionary.txt c83f765c66..., Last passed: Never
  • ccextractor --unixts 5 --out=txt c83f765c66..., Last passed: Never
  • ccextractor --out=txt --datets c83f765c66..., Last passed: Never
  • ccextractor --out=txt --sects c83f765c66..., Last passed: Never
  • ccextractor --out=txt --lf c83f765c66..., Last passed: Never
  • ccextractor --autodash --trim c83f765c66..., Last passed: Never
  • ccextractor --bufferinput c83f765c66..., Last passed: Never
  • ccextractor --no-bufferinput c83f765c66..., Last passed: Never
  • ccextractor --buffersize 1M c83f765c66..., Last passed: Never
  • ccextractor --dru c83f765c66..., Last passed: Never
  • ccextractor --no-rollup c83f765c66..., Last passed: Never
  • ccextractor --ru1 c83f765c66..., Last passed: Never
  • ccextractor --ru2 c83f765c66..., Last passed: Never
  • ccextractor --ru3 c83f765c66..., Last passed: Never
  • ccextractor --delay 200 c83f765c66..., Last passed: Never
  • ccextractor --startat 4 --endat 7 c83f765c66..., Last passed: Never
  • ccextractor --no-codec dvbsub c83f765c66..., Last passed: Never
  • ccextractor --debug --out=srt c83f765c66..., Last passed: Never
  • ccextractor --608 --out=srt c83f765c66..., Last passed: Never
  • ccextractor --708 --out=srt c83f765c66..., Last passed: Never
  • ccextractor --goppts --out=srt c83f765c66..., Last passed: Never
  • ccextractor --xdsdebug --out=srt c83f765c66..., Last passed: Never
  • ccextractor --vides --out=srt c83f765c66..., Last passed: Never
  • ccextractor --cbraw --out=srt c83f765c66..., Last passed: Never
  • ccextractor --no-sync --out=srt c83f765c66..., Last passed: Never
  • ccextractor --fullbin --out=srt c83f765c66..., Last passed: Never
  • ccextractor --parsedebug --out=srt c83f765c66..., Last passed: Never
  • ccextractor --parsePAT --out=srt c83f765c66..., Last passed: Never
  • ccextractor --parsePMT --out=srt c83f765c66..., Last passed: Never
  • ccextractor --investigate-packets --out=srt c83f765c66..., Last passed: Never
  • ccextractor --in=es dc7169d7c4..., Last passed: Never
  • ccextractor --in=asf 6395b281ad..., Last passed: Never
  • ccextractor --in=wtv b46e9e8e3f..., Last passed: Never
  • ccextractor --in=bin 988d4e8bba..., Last passed: Never
  • ccextractor --in=raw fb79021542..., Last passed: Never
  • ccextractor --in=mp4 b2771c84c2..., Last passed: Never
  • ccextractor --mp4vidtrack 5df914ce77..., Last passed: Never
  • ccextractor --wtvconvertfix acf871cbfd..., Last passed: Never
  • ccextractor --wtvmpeg2 10f0f77cf4..., Last passed: Never
  • ccextractor --hauppauge d6df1b227a..., Last passed: Never
  • ccextractor --codec dvbsub --out=spupng 85271be4d2..., Last passed: Never
  • ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
  • ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
  • ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
  • ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
  • ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
  • ccextractor --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Never
  • ccextractor --endcreditsforatleast 3 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Never
  • ccextractor --endcreditsforatmost 2 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Never
  • ccextractor --tpage 801 4e56e88ba4..., Last passed: Never
  • ccextractor --tverbose 4e56e88ba4..., Last passed: Never
  • ccextractor --teletext 4e56e88ba4..., Last passed: Never
  • ccextractor --out=txt --ucla c83f765c66..., Last passed: Never
  • ccextractor --xmltv=3 --out=null 96efd279cf..., Last passed: Never
  • ccextractor --datapid 2310 --autoprogram --out=srt --latin1 e639e54550..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 4e56e88ba4..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 b37ce60eb9..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 8c1615c1a8..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --tpage 299 44c45593fb..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --tpage 299 b8c55aa2e9..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 b236a0590b..., Last passed: Never
  • ccextractor --out=srt --latin1 f23a544ba8..., Last passed: Never
  • ccextractor --out=srt --latin1 97cc394d87..., Last passed: Never
  • ccextractor --out=srt --latin1 d7e7dbdf68..., Last passed: Never
  • ccextractor --out=srt --latin1 76734ac4a7..., Last passed: Never
  • ccextractor --out=srt --latin1 c791382c94..., Last passed: Never
  • ccextractor --out=srt --latin1 f673b2f916..., Last passed: Never
  • ccextractor --out=srt --latin1 da75bdee47..., Last passed: Never
  • ccextractor --out=srt --latin1 bd6f33a669..., Last passed: Never
  • ccextractor --out=srt --latin1 0e5e6b26be..., Last passed: Never
  • ccextractor --out=srt --latin1 a226cc302d..., Last passed: Never
  • ccextractor --out=srt --latin1 ae6327683e..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 725a49f871..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla d037c7509e..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --ucla d037c7509e..., Last passed: Never
  • ccextractor --autoprogram --out=smptett --latin1 --ucla e274a73653..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla e274a73653..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla 85058ad37e..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b22260d065..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --ucla b22260d065..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --xds --ucla c813e713a0..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --ucla c813e713a0..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 27fab4dbb6..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --ucla 27fab4dbb6..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds bbd5bb52fc..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --ucla bbd5bb52fc..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b992e0cccb..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds d0291cdcf6..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla 7d2730d38e..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --ucla 7d2730d38e..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds c8dc039a88..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --ucla c8dc039a88..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 53339f3455..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --ucla 53339f3455..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 83b03036a2..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --ucla 83b03036a2..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7d3f25c32c..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --ucla 7d3f25c32c..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds f41d4c29a1..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --ucla f41d4c29a1..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 88cd42b89a..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --ucla 88cd42b89a..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --output-field 2 --ucla 88cd42b89a..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7f41299cc7..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --ucla 7f41299cc7..., Last passed: Never

All tests passing on the master branch were passed completely.

Check the result page for more info.

@hrideshmg
Copy link
Contributor Author

@prateekmedia could you review this

@prateekmedia prateekmedia merged commit 6300bb7 into CCExtractor:master Aug 11, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants