-
Notifications
You must be signed in to change notification settings - Fork 517
refactor: remove api structures #1722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
prateekmedia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@hrideshmg why doesn't that one case from wtv work on windows? |
It seems to have timed out. WTV files currently take a long time to run and sometimes they hit the maximum allowed run duration. Will try to optimize them when I take an attempt at them later, its not caused by this PR at the very least. |
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit afde4d6...:
NOTE: The following tests have been failing on the master branch as well as the PR:
All tests passing on the master branch were passed completely. Check the result page for more info. |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit b63a29c...:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
All tests passing on the master branch were passed completely. Check the result page for more info. |
|
@prateekmedia could you review this |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Removes the API structures from
ccextractor.c. This was causing a regression due to mismatch between the options maintained byapi_optionsandccx_options.