[FIX] Regression bug failing to compile with ENABLE_FFMPEG

[rboy1]

In raising this pull request, I confirm the following (please check boxes):

• [ X] I have read and understood the contributors guide.
• [ X] I have checked that another pull request for this purpose does not exist.
• [ X] I have considered, and confirmed that this submission will be valuable to others.
• [X ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
• [X ] I give this submission freely, and claim no ownership to its content.
• [X ] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

• I have never used CCExtractor.
• I have used CCExtractor just a couple of times.
• I absolutely love CCExtractor, but have not contributed previously.
• [X ] I am an active contributor to CCExtractor.

---

Regression bug, ccextractor failed to build with ENABLE_FFMPEG using ffmpeg 5 libraries

Bug was introduced while patching in ref #1418 and #1479

[rboy1]

There are two more errors which popped up related to this during linking that need a patch. Do you want me to add the changes to this pull or should I create a new pull for it?

[prateekmedia]

@rboy1 separate PR if its unrelated.

[rboy1]

@rboy1 separate PR if its unrelated.

It's related to the FFMPEG 5 API changes (also builds with ffmpeg 7.1.1), updated the pull request to include those changes. I'm now able to build this without any errors. If you're good with it please go ahead and merge the changes.

[rboy1]

@cfsmp3

[cfsmp3]

@cfsmp3

It's falling tests, isn't it?

[rboy1]

@cfsmp3 doesn't seem related to this, all these are changes for code that fall under #ifdef ENABLE_FFMPEG to fix issues with building ccextractor when enabling ENABLE_FFMPEG and I don't see any build failures. The failures appear to be runtime related to DVD, 708. WTV etc and RUST coding (there are no changes to the RUST file it's says that is failing src/encoder/txt_helpers.rs) - none of the failures are related to changes that allow ccextractor to build when using ENABLE_FFMPEG.

It appears there may be other changes that have been committed to the master which may be causing those failures.

I see the same failures here: https://sampleplatform.ccextractor.org/test/6003
and it's for this pull that was committed to the master: #1729

Feel free to look at the changes and let me know if you think they're the cause of the test failures.

[rboy1]

Also seeing the same runtime failures with the latest commits to the master branch

#1710
https://sampleplatform.ccextractor.org/test/5954

#1714
https://sampleplatform.ccextractor.org/test/5995

[steel-bucket]

@rboy1 Actually those Failing Tests are a part of Rust Version 1.89, new changes to the clippy module(encoder was merged before that), It's fixed now, you could rebase and that error would go away.

[hrideshmg]

Yeah, please rebase. You're missing some commits from the master branch, this is why some of the sample platform tests are failing.

[ccextractor-bot]

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 39e051b...:

Report Name	Tests Passed
Broken	13/13
CEA-708	13/14
DVB	7/7
DVD	3/3
DVR-MS	2/2
General	27/27
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	85/86
Teletext	21/21
WTV	13/13
XDS	34/34

NOTE: The following tests have been failing on the master branch as well as the PR:

• ccextractor --service 1 --out=txt f17524b53f..., Last passed:

  Never

• ccextractor --unicode c83f765c66..., Last passed:

  Never

All tests passing on the master branch were passed completely.

Check the result page for more info.

[ccextractor-bot]

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 39e051b...:

Report Name	Tests Passed
Broken	13/13
CEA-708	13/14
DVB	4/7
DVD	3/3
DVR-MS	2/2
General	27/27
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	86/86
Teletext	21/21
WTV	10/13
XDS	34/34

NOTE: The following tests have been failing on the master branch as well as the PR:

• ccextractor --service 1 --out=txt f17524b53f..., Last passed:

  Never

• ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed:

  Never

• ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed:

  Never

• ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2..., Last passed:

  Never

• ccextractor --out=srt --latin1 f23a544ba8..., Last passed:

  Never

• ccextractor --out=srt --latin1 10f0f77cf4..., Last passed:

  Test 5993

• ccextractor --out=srt --latin1 df3b4d62d3..., Last passed:

  Never

Congratulations: Merging this PR would fix the following tests:

• ccextractor --autoprogram --out=srt --latin1 f1422b8bfe..., Last passed: Never
• ccextractor --datapid 5603 --autoprogram --out=srt --latin1 --teletext 85c7fc1ad7..., Last passed: Never
• ccextractor --out=spupng c83f765c66..., Last passed: Never
• ccextractor --unicode c83f765c66..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 006fdc391a..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 e92a1d4d2a..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 7e4ebf7fd7..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 9256a60e4b..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 297a44921a..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 efbe129086..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 eae0077731..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 c6407fb294..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 --datets dcada745de..., Last passed: Never
• ccextractor --autoprogram --out=srt --latin1 --tpage 398 5d5838bde9..., Last passed: Never
• ccextractor --autoprogram --out=srt --latin1 --teletext --tpage 398 3b276ad8bf..., Last passed: Never

All tests passing on the master branch were passed completely.

Check the result page for more info.

[rboy1]

Looks like it’s passing all the tests inline with the master baseline.

[prateekmedia]

LGTM!