[Rust]Ported AVC Module to Rust #1730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekmedia
reviewed
Sep 1, 2025
src/rust/src/avc/sei.rs
Outdated
| // Save the data and process once we know the sequence number | ||
| if ((ctx.cc_count as usize + local_cc_count) * 3) + 1 > ctx.cc_databufsize { | ||
| let new_size = ((ctx.cc_count as usize + local_cc_count) * 6) + 1; | ||
| ctx.cc_data.resize(new_size, 0); |
Member
There was a problem hiding this comment.
You can use this, it will be faster.
ctx.cc_data.reserve(new_size);
unsafe { ctx.cc_data.set_len(new_size); }
prateekmedia
reviewed
Sep 1, 2025
Comment on lines
+32
to
+34
| // TODO: This really really looks bad | ||
| info!("WARNING: Unexpected SEI unit length...trying to continue."); | ||
| // temp_debug = 1; // This appears to be a global debug flag - omitted in Rust version |
Contributor
Author
There was a problem hiding this comment.
Hi, that's not actually my comment. I decided to just preserve the TODOs I didn't know what to do with. If you want, I could try to implement a solution.
prateekmedia
reviewed
Sep 1, 2025
Comment on lines
+339
to
+341
| fn find_next_zero(slice: &[u8]) -> Option<usize> { | ||
| slice.iter().position(|&b| b == 0x00) | ||
| } |
Member
There was a problem hiding this comment.
You can SIMD optimize this function for faster outputs.
prateekmedia
reviewed
Sep 1, 2025
src/rust/src/avc/nal.rs
Outdated
| } | ||
|
|
||
| if (*dec_ctx.avc_ctx).pic_order_cnt_type == 1 { | ||
| panic!("In slice_header: AVC: ctx->avc_ctx->pic_order_cnt_type == 1 not yet supported."); |
Member
There was a problem hiding this comment.
You can replace panic! with Err(...)
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 3f44115...:
All tests passing on the master branch were passed completely. Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 3f44115...:
Congratulations: Merging this PR would fix the following tests:
All tests passing on the master branch were passed completely. Check the result page for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
This PR fixes the AVC functionality which was broken and migrates the entire
avc_functions.candavc_functions.hto Rust.tested on This AVC stream