Fix build with ffmpeg 8

[marillat]

Fix build with ffmpeg 8

In raising this pull request, I confirm the following (please check boxes):

• [ ]x I have read and understood the contributors guide.
• [ x] I have checked that another pull request for this purpose does not exist.
• [ x] I have considered, and confirmed that this submission will be valuable to others.
• [ x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
• [ x] I give this submission freely, and claim no ownership to its content.

[ccextractor-bot]

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 39e051b...:

Report Name	Tests Passed
Broken	13/13
CEA-708	13/14
DVB	7/7
DVD	3/3
DVR-MS	2/2
General	27/27
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	85/86
Teletext	21/21
WTV	13/13
XDS	34/34

NOTE: The following tests have been failing on the master branch as well as the PR:

• ccextractor --service 1 --out=txt f17524b53f..., Last passed:

  Never

• ccextractor --unicode c83f765c66..., Last passed:

  Never

All tests passing on the master branch were passed completely.

Check the result page for more info.

[ccextractor-bot]

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 39e051b...:

Report Name	Tests Passed
Broken	13/13
CEA-708	13/14
DVB	4/7
DVD	3/3
DVR-MS	2/2
General	27/27
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	86/86
Teletext	21/21
WTV	10/13
XDS	34/34

NOTE: The following tests have been failing on the master branch as well as the PR:

• ccextractor --service 1 --out=txt f17524b53f..., Last passed:

  Never

• ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed:

  Never

• ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed:

  Never

• ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2..., Last passed:

  Never

• ccextractor --out=srt --latin1 f23a544ba8..., Last passed:

  Never

• ccextractor --out=srt --latin1 10f0f77cf4..., Last passed:

  Test 5993

• ccextractor --out=srt --latin1 df3b4d62d3..., Last passed:

  Never

Congratulations: Merging this PR would fix the following tests:

• ccextractor --autoprogram --out=srt --latin1 f1422b8bfe..., Last passed: Never
• ccextractor --datapid 5603 --autoprogram --out=srt --latin1 --teletext 85c7fc1ad7..., Last passed: Never
• ccextractor --out=spupng c83f765c66..., Last passed: Never
• ccextractor --unicode c83f765c66..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 006fdc391a..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 e92a1d4d2a..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 7e4ebf7fd7..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 9256a60e4b..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 297a44921a..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 efbe129086..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 eae0077731..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 c6407fb294..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 --datets dcada745de..., Last passed: Never
• ccextractor --autoprogram --out=srt --latin1 --tpage 398 5d5838bde9..., Last passed: Never
• ccextractor --autoprogram --out=srt --latin1 --teletext --tpage 398 3b276ad8bf..., Last passed: Never

All tests passing on the master branch were passed completely.

Check the result page for more info.

[prateekmedia]

Hi @marillat, Is this change backwards compatible for let's say ffmpeg 5?

[prateekmedia]

I have asked @steel-bucket to test this on FFMpeg 5 and 8, will merge if it works on both.

[steel-bucket]

Hi, can you please tell me where it's not compiling? I checked with the latest release N-120821-g673f28b6cb-20250823 from here and the main branch compiles successfully with hardsubx and -DENABLE_SHARING

[marillat]

@steel-bucket With ffmpeg 8 ?
Also I'm talking about ccextractor 0.94
@prateekmedia I can't test with ffmpeg 5 as thos version is too old. We have only ffmpeg 7 in unstable and soon ffmpeg 8

[steel-bucket]

I checked with FFmpeg 8 and 6, yes, there was a seg fault with 8 in the main branch which this PR fixes. And it's also backwards compatible with FFMpeg 6.

[marillat]

@steel-bucket Do you have a command line to reproduce the crash ?

[prateekmedia]

@marillat Things are fine, the segfault was not in your branch.

[prateekmedia]

LGTM! Thanks.