fix: Enable stdout output for CEA-708 captions on Windows #1818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1693 - ccextractorwinfull.exe can't print captions to stdout
The CEA-708 decoder crashed on Windows when using
--stdoutbecause thedtvcc_writerwas not properly initialized for stdout output.Changes
Fixed Windows stdout handle initialization (
ccx_encoders_common.c):GetStdHandle(STD_OUTPUT_HANDLE)instead ofNULLforfhandleChanged env_logger target from Stdout to Stderr (
lib.rs):--stdoutRemoved redundant debug statement (
service_decoder.rs):debug!("{}", self.current_window)was noisy and duplicated by a more detailed debug statement below itTest plan
test_writer_output_with_valid_fd- verifies stdout mode works when fd is pre-settest_writer_output_missing_filename_and_fd- verifies proper error handling (not panic)GetStdHandle(STD_OUTPUT_HANDLE)API🤖 Generated with Claude Code