Skip to content

[FIX] Fix MSVC warning C4098: void function returning a value in networking.c #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfsmp3 merged 8 commits into from
Dec 30, 2025
Merged

[FIX] Fix MSVC warning C4098: void function returning a value in networking.c #1905

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6f7d3f6
Fix C4098 warnings in networking.c
VS7686 Dec 25, 2025
123b35a
Fix coding style and formatting
VS7686 Dec 26, 2025
46af5ce
Fix coding style and formatting
VS7686 Dec 26, 2025
826afcd
Fix styling: increase indentation inside ifndef
VS7686 Dec 26, 2025
5ae3116
Fix indentation: reduce to 4 spaces
VS7686 Dec 26, 2025
807df03
Fix styling: Apply clang-format
VS7686 Dec 26, 2025
f0523ce
Fix logic error: removed early returns to restore C implementation
VS7686 Dec 26, 2025
5eaf805
Add missing returns after Rust calls to prevent fallthrough
VS7686 Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/lib_ccx/networking.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ int set_nonblocking(int fd);
void connect_to_srv(const char *addr, const char *port, const char *cc_desc, const char *pwd)
{
#ifndef DISABLE_RUST
return ccxr_connect_to_srv(addr, port, cc_desc, pwd);
(void)ccxr_connect_to_srv(addr, port, cc_desc, pwd);
return;
#endif
if (NULL == addr)
{
Expand Down Expand Up @@ -137,7 +138,8 @@ void connect_to_srv(const char *addr, const char *port, const char *cc_desc, con
void net_send_header(const unsigned char *data, size_t len)
{
#ifndef DISABLE_RUST
return ccxr_net_send_header(data, len);
(void)ccxr_net_send_header(data, len);
return;
#endif
assert(srv_sd > 0);

Expand Down Expand Up @@ -188,7 +190,8 @@ int net_send_cc(const unsigned char *data, int len, void *private_data, struct c
void net_check_conn()
{
#ifndef DISABLE_RUST
return ccxr_net_check_conn();
ccxr_net_check_conn();
return;
#endif
time_t now;
static time_t last_ping = 0;
Expand Down Expand Up @@ -252,7 +255,8 @@ void net_send_epg(
const char *category)
{
#ifndef DISABLE_RUST
return ccxr_net_send_epg(start, stop, title, desc, lang, category);
(void)ccxr_net_send_epg(start, stop, title, desc, lang, category);
return;
#endif
size_t st;
size_t sp;
Expand Down
Loading