fix(windows): Bundle tessdata for OCR support out of the box #1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows release was missing Tesseract OCR runtime dependencies (tessdata files) needed for the HardSubx feature to work. Users had to manually install Tesseract OCR and set TESSDATA_PREFIX. Changes: - Add get_executable_directory() to ocr.c that returns the directory containing the executable (works on Windows, Linux, and macOS) - Update probe_tessdata_location() to search for tessdata in the executable directory, enabling bundled tessdata to be found - Update release workflow to download eng.traineddata and osd.traineddata from tesseract-ocr/tessdata_fast during release builds - Update WiX installer to include tessdata directory with the traineddata files Now the Windows release includes tessdata files, and CCExtractor will automatically find them in the installation directory without requiring users to install Tesseract separately or set environment variables. Fixes CCExtractor#1578 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 45ee03a...:
Your PR breaks these cases:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Windows release was missing Tesseract OCR runtime dependencies (tessdata files) needed for the HardSubx feature to work. Users had to manually install Tesseract OCR and set
TESSDATA_PREFIXenvironment variable.This PR fixes that by:
get_executable_directory()toocr.cthat finds the directory where CCExtractor is installed (works on Windows, Linux, and macOS)probe_tessdata_location()to search for tessdata in the executable directory, enabling bundled tessdata to be found automaticallyeng.traineddataandosd.traineddatafromtesseract-ocr/tessdata_fastduring release buildstessdata/directory with the traineddata filesNow the Windows release includes tessdata files, and CCExtractor will automatically find them in the installation directory without requiring users to install Tesseract separately or set environment variables.
Test plan
tessdata/eng.traineddataandtessdata/osd.traineddataFixes #1578
🤖 Generated with Claude Code