Skip to content

Fix buffer truncation warnings in EPG time strings #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harshdhall01 wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −6
Open

Fix buffer truncation warnings in EPG time strings #1910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
532f443
Fix buffer truncation warnings in EPG time strings
Harshdhall01 Dec 26, 2025
03d1810
Increase buffer size to 80 bytes to fully eliminate warnings
Harshdhall01 Dec 29, 2025
9270313
Add size parameter to EPG_ATSC_calc_time to eliminate hardcoded buffe…
Harshdhall01 Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib_ccx/ts_functions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ struct EPG_rating
struct EPG_event
{
uint32_t id;
char start_time_string[21]; //"YYYYMMDDHHMMSS +0000" = 20 chars
char end_time_string[21];
char start_time_string[80]; // Increased to prevent truncation warnings with large years
char end_time_string[80];
uint8_t running_status;
uint8_t free_ca_mode;
char ISO_639_language_code[4];
Expand Down
8 changes: 4 additions & 4 deletions src/lib_ccx/ts_tables_epg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ void EPG_ATSC_decode_ETT_text(uint8_t *offset, uint32_t length, struct EPG_event
}

// Fills given string with given (event.*_time_string) ATSC time converted to XMLTV style time string
void EPG_ATSC_calc_time(char *output, uint32_t time)
void EPG_ATSC_calc_time(char *output, size_t output_size, uint32_t time)
{
struct tm timeinfo;
timeinfo.tm_year = 1980 - 1900;
Expand All @@ -127,7 +127,7 @@ void EPG_ATSC_calc_time(char *output, uint32_t time)
timeinfo.tm_hour = 0;
timeinfo.tm_isdst = -1;
mktime(&timeinfo);
snprintf(output, 21, "%02d%02d%02d%02d%02d%02d +0000", timeinfo.tm_year + 1900, timeinfo.tm_mon + 1, timeinfo.tm_mday, timeinfo.tm_hour, timeinfo.tm_min, timeinfo.tm_sec);
snprintf(output, output_size, "%02d%02d%02d%02d%02d%02d +0000", timeinfo.tm_year + 1900, timeinfo.tm_mon + 1, timeinfo.tm_mday, timeinfo.tm_hour, timeinfo.tm_min, timeinfo.tm_sec);
}

// Fills event.start_time_string in XMLTV format with passed DVB time
Expand Down Expand Up @@ -1115,9 +1115,9 @@ void EPG_ATSC_decode_EIT(struct lib_ccx_ctx *ctx, uint8_t *payload_start, uint32
event.service_id = source_id;

start_time = (offset[2] << 24) | (offset[3] << 16) | (offset[4] << 8) | (offset[5] << 0);
EPG_ATSC_calc_time(event.start_time_string, start_time);
EPG_ATSC_calc_time(event.start_time_string, sizeof(event.start_time_string), start_time);
length_in_seconds = (((offset[6] & 0x0F) << 16) | (offset[7] << 8) | (offset[8] << 0));
EPG_ATSC_calc_time(event.end_time_string, start_time + length_in_seconds);
EPG_ATSC_calc_time(event.end_time_string, sizeof(event.end_time_string), start_time + length_in_seconds);

title_length = offset[9];
// XXX cant decode data more then size of payload
Expand Down
Loading