feat(scc): Add configurable frame rate and styled PAC codes for SCC output #1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utput This commit addresses the remaining items from issue #1191: 1. SCC Output Frame Rate: - Added scc_framerate to encoder_cfg and encoder_ctx structs - The --scc-framerate option now affects both input parsing AND output - Supports 24, 25, 29.97 (default), and 30 fps 2. Styled PAC (Preamble Address Code) Optimization: - Added support for styled PACs that encode color/font at column 0 - When captions start at column 0 with non-default style, uses a single styled PAC instead of indent PAC + mid-row code - More efficient output that matches professional SCC files Files changed: - ccx_common_option.h/c: Added scc_framerate to encoder_cfg - ccx_encoders_common.h/c: Added scc_framerate to encoder_ctx - ccx_encoders_scc.c: Added get_scc_fps(), styled PAC functions, and optimized write_cc_buffer_as_scenarist() - common.rs: Copy scc_framerate to enc_cfg Fixes #1191 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit b0800a1...:
Congratulations: Merging this PR would fix the following tests:
All tests passed completely. Check the result page for more info. |
Merged
2 tasks
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit b0800a1...:
Your PR breaks these cases:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the remaining items from issue #1191 (SCC/CCD format improvements):
--scc-framerateoption now affects both input parsing AND output encoding (was hardcoded to 29.97fps)Changes
1. SCC Output Frame Rate
scc_frameratetoencoder_cfgandencoder_ctxstructsget_scc_fps()helper function in SCC encoderadd_timestamp()to use configurable frame rate2. Styled PAC (Preamble Address Code) Optimization
get_styled_pac_byte2()- computes byte2 for styled PACs (0x40-0x4F range)row_uses_high_range()- determines which PAC byte range to usewrite_styled_preamble()- writes styled PAC directlycan_use_styled_pac()- checks if optimization applieswrite_cc_buffer_as_scenarist()to use styled PAC when appropriateThis resolves the TODO comment at line 487: "Preamble code need to take into account font as well"
Test plan
Issue Reference
Fixes #1191
🤖 Generated with Claude Code