fix: Apply --delay option to DVB/bitmap subtitles #1918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --delay option was not being applied to DVB and other bitmap-based subtitles (DVD subtitles, etc.), only to CEA-608 subtitles. This made it impossible for users to correct timing offsets in DVB subtitle extraction. Changes: - Add subs_delay to sub->start_time and sub->end_time for CC_BITMAP subtitles in encode_sub(), matching the behavior for CC_608 - Add bounds checking to skip subtitles that become negative after applying a negative delay - Properly free bitmap data when skipping to avoid memory leaks This provides a workaround for issue #1248 where DVB subtitles were extracted with incorrect timing offset. Users can now use --delay to adjust the timing. Fixes #1248 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit b6d7c7e...:
Your PR breaks these cases:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit b6d7c7e...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
--delayoption was not being applied to DVB and other bitmap-based subtitles (DVD subtitles, etc.), only to CEA-608 subtitles. This made it impossible for users to correct timing offsets in DVB subtitle extraction.Changes
subs_delaytosub->start_timeandsub->end_timeforCC_BITMAPsubtitles inencode_sub(), matching the behavior forCC_608Background
Investigation of issue #1248 revealed that while the original timing offset issue (6600ms too early) in certain DVB streams requires the sample file for root cause analysis, the
--delayoption should have been a viable workaround. However, the delay was never actually applied to bitmap-based subtitles.In
encode_sub()atccx_encoders_common.c:CC_608subtitles:subs_delaywas correctly appliedCC_BITMAPsubtitles:subs_delaywas never appliedTest plan
--delayoption works with DVB subtitlesRelated Issues
Fixes #1248 (provides workaround via
--delay)🤖 Generated with Claude Code