fix(avc): Remove unnecessary TODO for idr_pic_id #1947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the TODO comment at
src/lib_ccx/avc_functions.c:997and adds a clarifying comment explaining whyidr_pic_idis read but not stored.Why idr_pic_id doesn't need to be stored:
Bitstream parsing requirement: The value must be read to advance the bitstream position - subsequent fields like
pic_order_cnt_lsbcome after it in the slice headerNot needed for caption extraction: CCExtractor uses
pic_order_cnt_lsbfor frame ordering (when--usepicorderis set) and PTS for timing synchronization - neither requiresidr_pic_idPurpose in H.264:
idr_pic_iddistinguishes between consecutive IDR pictures for decoder error recovery - not relevant for extracting embedded captions from SEI NAL unitsCloses #1895
🤖 Generated with Claude Code