Fix MXF files containing CEA-708 captions not being detected/extracted #1977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cfsmp3
force-pushed
the
fix/issue-1647-mxf-708-captions
branch
from
cf33b6e to
ddf2967
Compare
Root cause: CCX_RAW_TYPE data from MXF demuxer was not being passed to the DTVCC decoder, only to the legacy 608 decoder via process_raw_with_field. Changes: - general_loop.c: Changed CCX_RAW_TYPE handling to use process_cc_data instead of process_raw_with_field to properly invoke DTVCC decoder - general_loop.c: Added DTVCC activation for MXF/GXF sources since they may contain 708 captions - general_loop.c: Initialize timing from caption PTS when not set - ccx_dtvcc.h: Added ccxr_dtvcc_set_active FFI declaration - lib.rs: Added ccxr_dtvcc_set_active function to enable DTVCC decoder - decoder/mod.rs: Fixed flush logic to always process visible windows - ccx_demuxer_mxf.c: Fixed PTS calculation to use 90kHz units based on edit_rate, and changed verbose logging to debug() Fixes #1647 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
cfsmp3
force-pushed
the
fix/issue-1647-mxf-708-captions
branch
from
ddf2967 to
6950a76
Compare
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 8c33412...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 8c33412...:
Your PR breaks these cases:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CCX_RAW_TYPEdata from MXF demuxer was only passed to the legacy 608 decoder, not the DTVCC decoder for 708 captionsCCX_RAW_TYPEhandling to useprocess_cc_datainstead ofprocess_raw_with_fieldTest plan
708cc_5seconds.mxf).p0.svc01.srtfileFiles changed
src/lib_ccx/general_loop.c- Main fix: route CCX_RAW_TYPE through DTVCC decodersrc/lib_ccx/ccx_dtvcc.h- Added FFI declaration forccxr_dtvcc_set_activesrc/rust/src/lib.rs- Addedccxr_dtvcc_set_activefunctionsrc/rust/src/decoder/mod.rs- Fixed flush logic for visible windowssrc/lib_ccx/ccx_demuxer_mxf.c- Fixed PTS calculation, changed verbose logging to debugFixes #1647
🤖 Generated with Claude Code