fix(matroska): abort parsing on invalid EBML ID to prevent infinite loop #2008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] matroska: Abort parsing on invalid element ID (0xFFFFFFFF) to prevent infinite loops
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Summary
This PR fixes a critical regression where the legacy C Matroska parser (
matroska.c) enters an infinite loop when encountering invalid EBML IDs (specifically0xFFFFFFFF) or EOF conditions inside segment/cluster loops.The Issue
In
parse_segment,parse_segment_cluster, and related functions, the loop structure was:skip_bytes.0xFFFFFFFF(EOF/Error),skip_bytesskips 0 bytes.The Fix
Added an explicit check for
code == 0xFFFFFFFFin the parsing loops. The parser now detects this "Invalid ID" state and aborts the loop gracefully with a specific error message.Verification
Tested against corrupted/truncated MKV samples that previously caused hangs.