docs: Clarify PS probe limit calculation (explain magic number) #2013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the magic number
49997with50000 - 3and adds a clear inline comment explaining the PS stream probe limit calculation.Changes
Why This Matters
The number 49997 appears arbitrary without context. The new code makes it clear that:
Why subtract 3: The loop checks
startbytes[i], [i+1], [i+2], [i+3], so we must stop 3 bytes before the end to avoid out-of-bounds accessWhy 50000: We cap the scan range for large buffers (no need to scan megabytes when 50KB is sufficient to detect the format)
Why saturating_sub: Handles edge case of tiny buffers (< 3 bytes) without underflow
Testing
🤖 Generated with Claude Code