Fix out-of-bounds panic in GXF VBI parsing#2069
Fix out-of-bounds panic in GXF VBI parsing#2069THE-Amrit-mahto-05 wants to merge 1 commit intoCCExtractor:masterfrom
Conversation
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 580e721...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 580e721...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
|
Closing due to inactivity — no updates since January. Feel free to reopen or submit a new PR if you'd like to continue this work. |
|
I just wanted to confirm that the fix on fix/gxf-vbi-bounds branch builds and runs successfully on macOS (arm64). I’ve tested it with a sample GXF file (video2_clip_fixed.gxf), and it no longer crashes it correctly processes the file, even though this particular test file didn’t contain captions. I’ve attached screenshots and a video to show the issue on the main branch and the fixed behavior on this branch: This demonstrates the fix is working correctly, and the branch can safely be merged into main. Let me know if you’d like me to reopen this PR or submit a new one with additional test cases for CI. |


In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Description
In userdata.rs, the GXF VBI parser was using an old data length after moving through the bitstream, which could crash on some files. This update checks the actual remaining bits instead, keeping things safe and stopping those crashes.