fix(ci): Get release commit from tag instead of stale last_commit

[cfsmp3]

Summary

This PR fixes an issue where release webhooks would create test entries with invalid or incorrect commit hashes (such as 0000000000000000000000000000000000000000).

The Problem

The previous code used last_commit from GeneralData to get the commit hash for releases. This is problematic because:

• last_commit represents HEAD of master at the time of the last push event
• It may not match the actual commit the release tag points to
• If webhooks arrive out of order or a release is created for an older tag, the commit would be wrong
• In some edge cases, it could be the Git null SHA which blocks subsequent tests

The Solution

1. New is_valid_commit_hash() helper function - Validates that a commit hash is:

   • Not empty/None
   • 7-40 characters (valid Git hash length)
   • Valid hexadecimal
   • Not the null SHA (all zeros)

2. Release webhook now fetches commit from tag - Uses GitHub API to get the actual commit:

   • Handles lightweight tags (point directly to commit)
   • Handles annotated tags (need to dereference to get commit)
   • Falls back to last_commit only if tag lookup fails

3. Validation in add_test_entry() - Rejects invalid commit hashes before creating test entries

4. Null-safe baseline update - Checks if test exists before trying to update baseline (prevents AttributeError crash)

Credit

Based on issue and approach identified by @NexionisJake in PR #937. This PR provides an improved implementation with:

• A reusable validation helper function
• Comprehensive unit tests
• Cleaner error handling

Test Plan

• New unit tests for is_valid_commit_hash() function
• New unit tests for release webhook with lightweight tags
• New unit tests for release webhook with annotated tags
• New unit tests for fallback behavior when tag lookup fails
• New unit tests for graceful failure with invalid commits
• Existing release webhook tests still pass

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.02%. Comparing base (78c3f60) to head (01d8ace).
⚠️ Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
mod_ci/controllers.py	93.47%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
+ Coverage   86.98%   87.02%   +0.04%     
==========================================
  Files          35       35              
  Lines        3780     3816      +36     
  Branches      774      783       +9     
==========================================
+ Hits         3288     3321      +33     
- Misses        354      356       +2     
- Partials      138      139       +1     

Flag	Coverage Δ
unittests	87.02% <93.47%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud