-
Notifications
You must be signed in to change notification settings - Fork 58
feat: Add version logging to VM scripts for audit trail #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #951 +/- ##
==========================================
+ Coverage 86.88% 86.93% +0.04%
==========================================
Files 35 35
Lines 3759 3796 +37
Branches 767 774 +7
==========================================
+ Hits 3266 3300 +34
- Misses 355 357 +2
- Partials 138 139 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e89d17e to
423ae18
Compare
423ae18 to
e59ebb2
Compare
e59ebb2 to
652c9a5
Compare
|
Thanks for the feedback @canihavesomecoffee! You're absolutely right about the security concern. I've updated the PR to remove all server-side binary execution: Removed:
Kept:
The VM-based approach is secure because each test runs in a fresh, disposable VM that gets destroyed after the test completes. The runCI scripts already log |
|
@cfsmp3 it seems that this PR conflicts a little with the previous one I merged. Care to rebase and fix the merge conflict (if one arises)? |
652c9a5 to
aef892c
Compare
- Update Linux runCI to log ccextractor --version before tests - Update Windows runCI.bat to log ccextractorwinfull.exe --version This ensures the binary version (including Git commit SHA) appears in the test logs, allowing verification that the correct binary is being tested. This runs safely in the isolated GCP VMs, not on the platform server. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
aef892c to
a90ade0
Compare
|



Summary
Adds version logging to the CI VM scripts so that test logs include the ccextractor binary version (including Git commit SHA).
Changes:
runCI: Logs./ccextractor --versionbefore running testsrunCI.bat: Logsccextractorwinfull.exe --versionbefore running testsThis allows verification that the correct binary version was tested by checking the test logs.
Security note: This runs in the isolated GCP VMs, not on the platform server, so there's no security risk from executing the binary.
Test plan
🤖 Generated with Claude Code