Skip to content

fix: Add retry logic to final GitHub status update #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfsmp3 merged 1 commit into from
Dec 27, 2025
Merged

fix: Add retry logic to final GitHub status update #977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions mod_ci/controllers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1933,8 +1933,16 @@ def progress_type_request(log, test, test_id, request) -> bool:
else:
message = progress.message

gh_commit = repository.get_commit(test.commit)
update_status_on_github(gh_commit, state, message, context, target_url=target_url)
# Use retry logic for final GitHub status update to prevent stuck "pending" states
# This is critical - if this fails, the PR will show "Tests queued" forever
try:
def update_final_status():
gh_commit = repository.get_commit(test.commit)
update_status_on_github(gh_commit, state, message, context, target_url=target_url)

retry_with_backoff(update_final_status, max_retries=3, initial_backoff=2.0)
except Exception as e:
log.error(f"Test {test_id}: Failed to update final GitHub status after retries: {e}")

if status in [TestStatus.completed, TestStatus.canceled]:
# Delete the current instance
Expand Down