Skip to content

ldexpf now correctly handles/rounds subnormal inputs #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 26, 2025
Merged

ldexpf now correctly handles/rounds subnormal inputs #620

merged 4 commits into from
Sep 26, 2025

Conversation

@ZERICO2005
Copy link
Contributor

@ZERICO2005 ZERICO2005 commented Jul 18, 2025

ldexpf/scalbnf now correctly handles/rounds subnormal inputs/outputs.

Since Ti's floats don't support negative zero, ldexpf also has a __ldexpf_avoid_negative_zero option (set to 1 currently), which guarantees that negative zero is only returned if the input is negative zero.

@ZERICO2005
Copy link
Contributor Author

ZERICO2005 commented Sep 9, 2025

I suppose this implementation of ldexpf is fine for now. Later on we could use ez80sf routines to speedup the handling of subnormal values.

@ZERICO2005 ZERICO2005 marked this pull request as ready for review September 13, 2025 20:52
@adriweb
Copy link
Member

adriweb commented Sep 26, 2025

Good job on the many tests, i'm going to merge that trusting those

@adriweb adriweb merged commit 5c31b2f into master Sep 26, 2025
9 checks passed
@adriweb adriweb deleted the subnormal_ldexpf branch September 26, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calc84maniac calc84maniac Awaiting requested review from calc84maniac

Assignees

No one assigned

Labels

libc

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZERICO2005 @adriweb