Add run-time interface for build-time configuration#1792
Merged
Conversation
239b595 to
681b597
Compare
jedbrown
commented
Mar 22, 2025
Collaborator
|
IDK if it's relevant for this feature, but if I try and run I didn't get this error when I ran it on a branch initially, but now it only returns the error after pulling main. Edit: This is with git version Edit 2: |
b56a17d to
8edc248
Compare
jeremylt
reviewed
Mar 25, 2025
This adds CeedGetGitVersion() to access output of `git describe --dirty` and CeedGetBuildConfiguration() to get variables like compilers and flags. For builds without a Git repo, we return "unknown" or the user can set the string via `make GIT_DESCRIBE=deadbeaf`.
cc4fdef to
e01c415
Compare
cef960b to
9a896d0
Compare
9a896d0 to
d7fa60a
Compare
Member
|
Issue was that old versions of make do not have With these changes: |
jrwrigh
approved these changes
Mar 25, 2025
d224447 to
518f111
Compare
jeremylt
reviewed
Mar 25, 2025
c22b1ae to
518f111
Compare
518f111 to
944f002
Compare
jeremylt
reviewed
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides the interfaces requested in #1732