Conversation
jeremylt
force-pushed
the
jeremy/name-consistency
branch
2 times, most recently
from
161723c to
4c633d2
Compare
Member
Author
|
Duh, forgot I could move some of the tests to dev only |
Member
|
This seems like only a naming convention thing, and like it would be possible to preserve deprecated stubs for the old names. That would ease migration at what looks to be minimal cost. |
Member
Author
|
Yeah, preserving the stubs to the handful of old names would be easy. |
jeremylt
force-pushed
the
jeremy/name-consistency
branch
2 times, most recently
from
df74f3e to
ba68461
Compare
jrwrigh
reviewed
Jul 26, 2025
jeremylt
force-pushed
the
jeremy/name-consistency
branch
4 times, most recently
from
567ea5b to
b039254
Compare
jeremylt
force-pushed
the
jeremy/name-consistency
branch
from
b039254 to
52b0e56
Compare
Member
Author
|
Any objections to merging this now? I think its ready |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have
CeedBasisCreateH1and similar for almost all objects. I'm not sure why we treatCeedCompositeOperatorCreatedifferently?