Add versioned outcomes schema #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahouseholder
requested changes
Jan 24, 2025
src/cvss_to_json.py
Outdated
| #user_interaction USER_INTERACTION_2 | ||
| print(mod, dp) | ||
| sdp = getattr(module, dp) | ||
| f = open(f"../data/json/decision_points/cvss/{dp.lower()}.json", "w") |
Contributor
There was a problem hiding this comment.
Purely a syntactical note, not worth changing, just mentioning it since I noticed it here.
with open("...","w") as f:
f.write("foo")
does the same thing but you don't have to explicitly close() because the context manager handles it for you.
Contributor
Author
There was a problem hiding this comment.
will do with syntax...
Contributor
|
Also note that we'll need to do a brief reconciliation of #674 with this one, just depends on merge order which one will need to change. |
ahouseholder
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to move towards Policy Explorer which requires Outcomes and resolves #589 so we have a schema for the outcome groups.
Here is what has happened
Mostly additions should not disturb any setup.