-
Notifications
You must be signed in to change notification settings - Fork 42
Dockerize the mkdocs dev server #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize-the-mkdocs-dev-server # Conflicts: # README.md
Contributor
|
May need to reset this to an earlier commit and catch up with the changes. The lint checks will also need to be satisfied in the markdown format. |
…com/CERTCC/SSVC into 582-dockerize-the-mkdocs-dev-server
Contributor
Author
sei-renae
reviewed
Feb 19, 2025
sei-renae
reviewed
Feb 19, 2025
sei-renae
reviewed
Feb 19, 2025
Contributor
Author
|
Converting back to draft until i have a chance to address feedback above. |
sei-renae
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modularizes the existing Dockerfile to let us have different targets for
testanddocs. It also adds aMakefileto reduce the need for folks to remember complicated docker commands.Copilot summary
This pull request includes significant updates to the Docker setup, Makefile, and README documentation to streamline the development workflow and improve clarity on how to build and run the project. Below are the most important changes:
Dockerfile Improvements:
pip install --upgrade pipto ensure the latest version of pip is used.COPYcommands to simplify file inclusion and set thePYTHONPATHenvironment variable.Makefile Additions:
cleantarget to remove Docker images andhelptarget to display usage instructions.Documentation Enhancements:
makeinstalled. [1] [2]