Replace Track*/Track * with Monitor in CISA-based decision model (2nd try)
#742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation-of-cisas-tree
sei-vsarvepalli
approved these changes
Jun 23, 2025
Contributor
sei-vsarvepalli
left a comment
sei-vsarvepalli
left a comment
There was a problem hiding this comment.
I think some of these will get overridden with the later PR's but approving it anyway. so it is not blocked.
ahouseholder
added
content/semantic
Contributor
|
This PR should probably be abandoned as these changes will go into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #738, which we merged too soon and reverted in #741
This PR modifies the "Track *" value in the CISA OutcomeGroup to be "Monitor". Based on feedback received that having two closely-named values "Track" and "Track *" can be a source of confusion for users of that outcome group.
Two incidental changes are also included:
keyvalues forAttendandActin the python version of the CISA OutcomeGroup to match the keys found indocs/ssvc-calc/CISA-Coordinator.jsontupleinstead of alist)CoPilot Summary
This pull request includes several updates to the
docs/ssvc-calcandsrc/ssvc/outcomesdirectories to standardize terminology and improve code structure. The most important changes include renaming "Track*" to "Monitor" in JSON and HTML files, updating theOutcomeGroupclass to use tuples instead of lists, and restructuring outcome groups in the codebase.Terminology Standardization:
docs/ssvc-calc/CISA-Coordinator.json: Renamed "Track*" to "Monitor" in multiple entries to standardize terminology. [1] [2] [3] [4] [5]docs/ssvc-ccalc/findex.htmlanddocs/ssvc-calc/old_index.html: Updated "Track*" to "Monitor" in the vulnerability scoring decisions section. [1] [2]Code Structure Improvements:
src/ssvc/outcomes/base.py: Changed theoutcomesattribute in theOutcomeGroupclass from a list to a tuple for better immutability and performance.src/ssvc/outcomes/groups.py: Updated theOutcomeGroupinstances to use the new "Monitor" terminology and restructured the CISA outcome group. Additionally, added new descriptions and keys for the "Act" outcome. [1] [2] [3] [4] [5] [6]