-
Notifications
You must be signed in to change notification settings - Fork 42
Separating how-to guides ('gathering info' sections) from reference documents #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please consider which/whether this PR is intended to address:
If it is, update the resolution keywords in the description accordingly. |
|
moving the "gathering information" sections to the how to instead of reference like this makes sense to me. |
ahouseholder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the split of Gathering Info off into the HowTo section of the docs. That part is fine.
- What I'm left with though is that in
docs/reference/decision_points/*there are (at least as of the current commit) no breadcrumbs pointing from the reference doc to the corresponding howto doc.
I suggest leaving something akin to the following behind in each of the relevant reference pages.
!!! tip Gathering Information about Foo
See this [HowTo](link) for advice on gathering information about the Foo decision point.Adjust wording to taste, I'm mostly concerned that (a) there is a link to it, and (b) it's probably in a call-out.
- In the new "HowTo" pages, I think it would make sense to also include the current version example block somewhere near the top of the page.
python exec="true" idprefix=""
from ssvc.decision_points.ssvc.automatable import LATEST
from ssvc.doc_helpers import example_block
print(example_block(LATEST))Other than that I can't think of anything else at the moment.
|
I had previously commented:
After conversations with @sei-renae, I believe this PR, once complete, would resolve #723 and #537, while leaving #522 and #362 as future work. I added closing keywords to the PR description consistent with this observation. |
ahouseholder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few fixes directly before doing this review. There are still a few changes I'd like to see before we finish this per comments that follow.
sei-vsarvepalli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All markdown changes checkout fine.
ahouseholder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple previous comments remain unresolved, and I had a couple new ones on this revision. In particular, the sentence fragment in Human Impact is a blocker for merging.
|
@ahouseholder I think I got it all this time |
Gathering Info...sections of Decision Point reference pages #537