Skip to content

Fix for Bug paging issue #818 #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahouseholder merged 2 commits into from
Jul 18, 2025
Merged

Fix for Bug paging issue #818 #822

ahouseholder merged 2 commits into from
Jul 18, 2025

Conversation

@sei-vsarvepalli
Copy link
Contributor

@sei-vsarvepalli sei-vsarvepalli commented Jul 15, 2025

This is to fix issue #818 paging issue with PDF exporter.

@sei-vsarvepalli sei-vsarvepalli self-assigned this Jul 15, 2025
@sei-vsarvepalli
Copy link
Contributor Author

sei-vsarvepalli commented Jul 15, 2025

This is a simpler update for the old JavaScript code to support PDF export and fix lack of image that is needed for the exporter to work.

@ahouseholder ahouseholder requested a review from sei-renae July 16, 2025 15:56
@ahouseholder ahouseholder added bug Something isn't working demo site Demo site and production site content labels Jul 16, 2025
@ahouseholder ahouseholder added this to the 2025-09 milestone Jul 16, 2025
@ahouseholder ahouseholder linked an issue Jul 16, 2025 that may be closed by this pull request
PDF Exports cut off at 1 page #818
Closed
sei-renae
sei-renae approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@sei-renae sei-renae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used the steps to reproduce #818 to successfully create a multi-page PDF using a branch for #822

@ahouseholder ahouseholder merged commit 30f0a90 into CERTCC:main Jul 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sei-renae sei-renae sei-renae approved these changes

@ahouseholder ahouseholder Awaiting requested review from ahouseholder ahouseholder is a code owner

@cgyarbrough cgyarbrough Awaiting requested review from cgyarbrough

Assignees

@sei-vsarvepalli sei-vsarvepalli

Labels

bug Something isn't working demo site Demo site and production site content

Projects

None yet

Milestone

2025-09

Development

Successfully merging this pull request may close these issues.

PDF Exports cut off at 1 page

3 participants

@sei-vsarvepalli @sei-renae @ahouseholder