-
Notifications
You must be signed in to change notification settings - Fork 42
DecisionTable to mermaid
#886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not quite right yet
…on table presentation
…r match prior documentation
This was referenced Aug 18, 2025
sei-vsarvepalli
approved these changes
Aug 18, 2025
j---
reviewed
Aug 19, 2025
Collaborator
j---
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the mermaid implementation, so I can't really review the code, but given that the test works, it LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content/representation
Formatting, page layout, syntax, etc.
enhancement
New feature or request
python
Pull requests that update Python code
tech/backend
Back-end tools, code, infrastructure
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DecisionTableobjects #869DecisionTableto Mermaid diagrams #884 (this PR resubmitting from a main repo branch)This PR adds tools to generate a
mermaiddiagram from aDecisionTableobject.It also adds a method that lets us generate the markdown table format directly from the
DecisionTableobject insteadof loading a
.csvfile.The main changes can be found in
src/ssvc/decision_tables/helpers.py. Everything else is incidental.Note
mermaidhas a default limit of 500 edges per diagram to prevent unreasonably long browser load times. In this implementation, we first attempt to generate a single diagram. If the edge count exceeds the limit, we split it across the first decision point values (each one gets its own diagram). So far this is sufficient for all the decisions we currently have models for. If we need a more robust solution later, we can address this in a future PR.Incidental changes
COORDINATEdecision point to better reflect existing documentation.DecisionTableimplementation.Copilot Summary
This pull request updates the SSVC "Decline, Track, Coordinate" outcome group to version 1.0.1 and ensures that all relevant references in the
coordinator_triage_1_0_0.jsondecision table use the new version. The new version provides more descriptive explanations for each outcome, improving clarity and consistency across the data.Key changes:
Outcome group update and improved descriptions:
decline_track_coordinate_1_0_1.jsondefining the "Decline, Track, Coordinate" group with detailed descriptions for each value, clarifying what each outcome means.coordinator_triage_1_0_0.jsonfrom version 1.0.0 to 1.0.1, and replaced the brief descriptions with the improved ones from the new version.Decision table consistency:
coordinator_triage_1_0_0.jsonto referencessvc:COORDINATE:1.0.1instead of the old version, ensuring the decision table consistently uses the new outcome group. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27] [28] [29] [30] [31] [32] [33] [34] [35] [36] [37]