Add 'invalid' to the registered namespaces#915
Closed
ahouseholder wants to merge 2 commits intomainfrom
Closed
Conversation
ahouseholder
added
tech/backend
… to validator to skip pattern matching on explicitly registered namespaces.
ahouseholder
changed the title
x_invalid to the registered namespaces
tschmidtb51
reviewed
Aug 26, 2025
Contributor
tschmidtb51
left a comment
tschmidtb51
left a comment
There was a problem hiding this comment.
I wonder whether that makes sense from a usage point and the intended purpose: things should fail with the registered namespace. I know that having a registered namespace that is not registered in the code sounds awkward - but that is actually the point.
So, I think this should just go into the documentation as reserve namespace for special use (similar to example, testand x_example - see also #907 (comment))
tschmidtb51
suggested changes
Aug 27, 2025
Contributor
There was a problem hiding this comment.
Please see: #907 (comment)
Edit: After giving it another though: I changed assessment from comment (last night) to request changes as I think invalid can't be in the code if it should work as intended.
Contributor
Author
|
Withdrawing this PR until we get to resolution on #907 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invalid#907The original issue also mentions
x_invalid, however, if we addx_invalidto the registered namespaces, it will fail to match the namespace pattern because the pattern assumes anything that starts withx_will have a fragment. So I'm leaving that out of this PR in the interest of keeping the PR simple.