-
Notifications
You must be signed in to change notification settings - Fork 42
Rename description attribute to definition
#926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sing weird .venv interactions with host system in dev (cherry picked from commit 51f345e9840ccd0eafb44e68b4a1032fa7ddc4d9)
description attribute to definition
|
Okay we are jumping on this one! running some tests first.. |
|
Some tests for generating schema are failing, when trying to recreate the schema and test it. These may have been failing before. Should we fix it? The namespace is missing it says, but when namespace is provided it still fails. |
|
Also the SSVC object ID validator is somewhere not right too. |
|
@sei-vsarvepalli running I'm getting 175 passing tests with |
…come broken as the object has evolved. So I'm just taking it out lest it lead others astray in troubleshooting.
description#903Renames the
descriptionattribute inssvc._mixins._Basetodefinition. All other changes are incidental to that one change.Important
This PR touches a lot of files, so pay attention to merge order if you're merging more than one PR in rapid succession.
Anticipate that outstanding branches may have merge conflicts.