Skip to content

pytrap: improved error message on bad UniRec field redefinition #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2024
Merged

pytrap: improved error message on bad UniRec field redefinition #234

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e0a01b
pytrap: improved error message on bad UniRec field redefinition
cejkato2 Oct 9, 2024
c2e3d69
pytrap: improved error message
cejkato2 Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion pytrap/src/unirecmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2095,7 +2095,20 @@ UnirecTemplate_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
self->urtmplt = NULL;
int ret;
if ((ret = ur_define_set_of_fields(spec)) != UR_OK) {
PyErr_SetString(TrapError, "ur_define_set_of_fields() failed.");
switch (ret) {
case UR_E_INVALID_NAME:
PyErr_SetString(TrapError, "ur_define_set_of_fields() failed due to bad name of some field in the template. The name must start with letter [a-zA-Z] and can contain only [a-zA-Z0-9_].");
break;
case UR_E_TYPE_MISMATCH:
PyErr_SetString(TrapError, "ur_define_set_of_fields() failed because some field with the existing name is being redefined with a different type, which is not allowed.");
break;
case UR_E_MEMORY:
PyErr_SetString(TrapError, "ur_define_set_of_fields() failed due to memory allocation error.");
break;
default:
// this should not happen...
PyErr_SetString(TrapError, "ur_define_set_of_fields() failed due to unkown reason.");
}
Py_DECREF(self);
return NULL;
}
Expand Down
Loading