You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Did funnies, all tests seem to pass (GLuaTest & gmod_tests) / no new issues seem to appear
Could probably try to push it further by unpacking the vpk files and merging all into one content directory to avoid duplicate files (iirc VPK files love to have duplicate content)
Depends on #108 as without the build still fails due to steamcmd
Docker slim already removes a lot xd
all content_hl2_*, content_cstrike_*, hl2_textures_*, hl2_sound_vo_english_*, hl2_sound_misc_000 & hl2_sound_misc_002 are all already being nuked soo just finishing that a bit for an benefit doens't seem like it would hurt much at that point
Most content either seems to be in hl2_misc_00x.vpk or garrysmod_00x.vpk
The content pack content_hl2_005 & hl2_sound_misc_001 don't seem to contain any content that is used by any tests / I saw no errors related to missing things
Also removing all the _dir.vpk's of dead packs like content_cstrike_dir.vpk and such solves all the NULL FileHandle errors, as it won't try to read imaginary vpk files anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did funnies, all tests seem to pass (GLuaTest & gmod_tests) / no new issues seem to appear
Could probably try to push it further by unpacking the vpk files and merging all into one content directory to avoid duplicate files (iirc VPK files love to have duplicate content)
Depends on #108 as without the build still fails due to steamcmd