Skip to content

Conversation

@sarahsturgeon
Copy link
Member

Thanks to our friend @timschumi implementing our request, we're able to use the new OnCHTTPRequest hook 👍

(didn't test this yet)

@sarahsturgeon sarahsturgeon self-assigned this Oct 7, 2025
@sarahsturgeon sarahsturgeon added the enhancement New feature or request label Oct 7, 2025
@timschumi
Copy link

On another (slightly selfish) note, is there a chance that we could get chttp.timschumi.net into the default list of allowed domains at the same time?

While the update/statistics checkin is currently not hooked up to OnCHTTPRequest due to technical reasons, I eventually want to make that the case so that people who want to disable that feature can simply drop a file into the autorun directory. However, at the moment, the whitelist would by default cut off people from update notifications and make my statistics about the distribution of configurations a bit lopsided.

@plally
Copy link
Member

plally commented Oct 7, 2025

On another (slightly selfish) note, is there a chance that we could get chttp.timschumi.net into the default list of allowed domains at the same time?

While the update/statistics checkin is currently not hooked up to OnCHTTPRequest due to technical reasons, I eventually want to make that the case so that people who want to disable that feature can simply drop a file into the autorun directory. However, at the moment, the whitelist would by default cut off people from update notifications and make my statistics about the distribution of configurations a bit lopsided.

We could add it as an optional config thats just loaded if they have the module, like we do with starfall here

@timschumi
Copy link

We could add it as an optional config thats just loaded if they have the module, like we do with starfall here

Ah, I didn't notice that there already is a conditional system as well.

Only problem now is figuring out the condition, we can't rely on anything that CHTTP itself sets (e.g. CHTTP_VERSION) because that is only observable after the checkin has been scheduled and I'm not entirely up-to-date on whether file.* allows for checking for the presence of DLL files in garrysmod/lua/bin.

@plally
Copy link
Member

plally commented Oct 7, 2025

I think we can just use https://wiki.facepunch.com/gmod/util.IsBinaryModuleInstalled

@timschumi
Copy link

timschumi commented Oct 18, 2025

Fixed up the stack thing and added the exception, feel free to pull in from 052380d and 2e67108 (the latter being the HEAD).

Other than that everything seems to work as expected.

@timschumi
Copy link

Bildschirmfoto_20251019_012039

I'll see if I can elegantly fix the NONE request type on the CHTTP side (assuming HTTP doesn't have the same problem), probably involves defaulting the table entries to their respective defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants