Skip to content

Conversation

@StrawWagen
Copy link
Contributor

No description provided.

Copy link
Member

@sarahsturgeon sarahsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd strongly suggest checking the classname of each entity and erroring if it doesn't exist or doesn't match the expected classname 👍

@StrawWagen StrawWagen merged commit 2bf1878 into main Jan 3, 2026
1 check passed
@StrawWagen StrawWagen deleted the vacant_industry branch January 3, 2026 01:54
@sarahsturgeon
Copy link
Member

I don't think ENHWS gets caught by err forwarder; might want to error instead? No use continuing if the indices have been thrown off.

Maybe a bit autistic but I'd wager it'd even be safer to make sure they're all valid before removing any of them

@StrawWagen
Copy link
Contributor Author

It shoould work.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants