Fix sampling of vector_t quantities#530
Closed
lisataldir wants to merge 0 commit intoCFD-GO:developfrom
Closed
Conversation
llaniewski
requested changes
Sep 4, 2025
src/Sampler.cpp
Outdated
| for (const auto& quantity : model->quantities) { | ||
| if (quant->in(quantity.name)) { | ||
| if (quantity.isVector) { | ||
| real_t *tmp = (real_t *)malloc(3*sizeof(real_t)); |
Member
There was a problem hiding this comment.
Please change this to a static array real_t tmp[3]. It doesn't make sense to dynamically allocate such a small thing of constant size.
lisataldir
force-pushed
the
feature/handlers
branch
from
7e5bc60 to
66cad5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed a segmentation fault that appears in the function writeHistory of the Sample.cpp file when using the handler with vector_t quantities