Used some flake8 rules to clean up the code a bit more#73
Open
marksmayo wants to merge 7 commits intoCFMTech:masterfrom
Open
Used some flake8 rules to clean up the code a bit more#73marksmayo wants to merge 7 commits intoCFMTech:masterfrom
marksmayo wants to merge 7 commits intoCFMTech:masterfrom
Conversation
- sorted imports - black formatting - whitespace cleaned - consistenet quoting - fstrings created
backdated fstring to format strings
C812 missing trailing comma
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
Author
|
It looks like when I pulled, I got a new setup.py and it's having issues install? |
Collaborator
|
Hello! Thanks for reaching out! For development purpose: For simple install: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Used flake8 to identify some issues
Style and cleanliness change
Checklist:
Status: Code Review Needed,Business: Test NeededorStatus: In Progressif you are still working on the PR)Do not forget to @ the people that needs to do the review