Add description to additional elements #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @CGA1123 just a friendly bump here |
Owner
|
Hi @resputin! Really sorry, completely missed this PR opening 😄 Thanks for the ping, will take a look this weekend. Appreciate you taking the time to resolve this issue 🙇 |
Contributor
Author
|
Awesome! Thanks so much |
CGA1123
approved these changes
Nov 22, 2024
Owner
CGA1123
left a comment
CGA1123
left a comment
There was a problem hiding this comment.
Ah, looks like my CI config is broken... Have run this locally and aside from a small linting issue, LGTM! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds description support to elements that were previously missing it, as reported in #181. Specifically, it adds description functionality to:
Additionally, while implementing this fix, I discovered and added description support to OptionGroup components, which was necessary for descriptions to work properly in elements using option groups.