Open
Conversation
and add named parameter edge_is_feature_map
TODO : collect sharp vertices that are not incident to sharp edges
…p_corners # Conflicts: # BGL/include/CGAL/boost/graph/parameters_interface.h
Member
|
Now vertices incident to 1 or more than 2 sharp edges are set to be "sharp".
This PR is very related to #4084 that includes experimental code for features detection |
Member
|
@janetournois still targeting 5.4? |
Member
Jane, do we still want it for next release? The code freeze is... supposed to be today. |
Member
|
Sorry I had missed the previous message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds the function detect_sharp_corners to detect sharp corners as addressed in issue #1708
Release Management