Skip to content

add detect sharp corners#5710

Open
kabirkedia wants to merge 41 commits intoCGAL:mainfrom
kabirkedia:kabir-add_detect_sharp_corners
Open

add detect sharp corners#5710
kabirkedia wants to merge 41 commits intoCGAL:mainfrom
kabirkedia:kabir-add_detect_sharp_corners

Conversation

@kabirkedia
Copy link
Copy Markdown

Summary of Changes

Adds the function detect_sharp_corners to detect sharp corners as addressed in issue #1708

Release Management

@lrineau lrineau added CLA/CAA The contributor must sign a CLA or a CAA so that the contribution can be merged into CGAL and removed CLA/CAA The contributor must sign a CLA or a CAA so that the contribution can be merged into CGAL labels Aug 19, 2021
@janetournois
Copy link
Copy Markdown
Member

Now vertices incident to 1 or more than 2 sharp edges are set to be "sharp".
There are two more cases to handle :

  1. vertices incident to exactly 2 sharp edges that form a sharp angle together
  2. vertices incident to no sharp edges and that form a sharp angle (like the tip of a cone)

This PR is very related to #4084 that includes experimental code for features detection

@sloriot
Copy link
Copy Markdown
Member

sloriot commented Sep 23, 2021

@janetournois still targeting 5.4?

@sloriot sloriot modified the milestones: 5.4-beta, 5.5-beta1 Sep 30, 2021
@lrineau
Copy link
Copy Markdown
Member

lrineau commented Sep 30, 2021

@janetournois still targeting 5.4?

Jane, do we still want it for next release? The code freeze is... supposed to be today.

@janetournois
Copy link
Copy Markdown
Member

Sorry I had missed the previous message.
There is no small feature yet so let's postpone it to 5.5, and make it complete by then

@sloriot sloriot modified the milestones: 5.5-beta, 5.6-beta Apr 12, 2022
@MaelRL MaelRL modified the milestones: 5.6-beta, 5.7-beta Mar 31, 2023
@janetournois janetournois modified the milestones: 6.0-beta, 6.1-beta May 16, 2024
@MaelRL MaelRL modified the milestones: 6.1-beta, 6.2-beta Mar 17, 2025
@sloriot sloriot changed the base branch from master to main September 16, 2025 19:21
@MaelRL MaelRL modified the milestones: 6.2-beta, 6.3-beta Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvements for PMP::isotropic_remeshing

6 participants