Minimal angle remeshing by KaimoHu · Pull Request #5939 · CGAL/cgal

KaimoHu · 2021-08-28T08:59:30Z

Summary of Changes

Implemented the algorithm, documentation and plugin of minimal_angle_remeshing.

Release Management

Affected package(s): Polygon Mesh Processing
Issue(s) solved (if any): None
Feature/Small Feature (if any): None
Link to compiled documentation (obligatory for small feature) wrong link name to be changed
License and copyright ownership: INRIA Sophia-Antipolis (France)

sloriot · 2021-08-30T14:34:49Z

Hi Kaimo, the issue in the check is that it seems that Surface_mesh is hard coded as mesh data structure in the new meshing function. This introduces a new dependency for the PMP package. I'll have a look if it is not too much work to remove it.

In the meantime, it would be great if you can update the user manual (Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt) and add a section about the new method. In particular, there should also be a section that is describing in which case the new function should be used over isotropic_remeshing() and the converse. This would make things clearer for the users of the library.

KaimoHu · 2021-08-31T02:20:47Z

Hi Kaimo, the issue in the check is that it seems that Surface_mesh is hard coded as mesh data structure in the new meshing function. This introduces a new dependency for the PMP package. I'll have a look if it is not too much work to remove it.

In the meantime, it would be great if you can update the user manual (Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt) and add a section about the new method. In particular, there should also be a section that is describing in which case the new function should be used over isotropic_remeshing() and the converse. This would make things clearer for the users of the library.

Hi Sebastien, thanks for checking the Surface_mesh issue. Please let me know if you have finished it.

I have updated the user manual (Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt), and commited to the PR. Please let me know if further actions are required from my side.

sloriot · 2021-08-31T08:53:05Z

/build:v0

github-actions · 2021-08-31T08:57:21Z

There was an error while building the doc:
warning: tag INPUT: input source `/CGAL/Polygon_mesh_processing/minimal_angle_remeshing.h' does not exist

sloriot · 2021-08-31T09:37:42Z

/build:v0

github-actions · 2021-08-31T09:42:00Z

There was an error while building the doc:
/home/runner/work/cgal/cgal/Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt:143: warning: cite command to 'hu2017TVCG' does not have an associated number

KaimoHu · 2021-08-31T09:49:27Z

There was an error while building the doc:
warning: tag INPUT: input source `/CGAL/Polygon_mesh_processing/minimal_angle_remeshing.h' does not exist

This problem has been solved.

sloriot · 2021-08-31T10:52:10Z

/build:v0

github-actions · 2021-08-31T10:56:44Z

The documentation is built. It will be available, after a few minutes, here : https://cgal.github.io/5939/v0/Manual/index.html

…al of PMP

KaimoHu · 2021-08-31T13:36:39Z

/build:v0

Hello Sebastien, could you please build the documentation again? I just modified the section minimal_angle_remeshing in the user manual, and would like to see whether it better than before.

sloriot · 2021-09-01T12:38:52Z

/forcebuild:v0

KaimoHu · 2021-09-02T02:03:35Z

/forcebuild:v0

The documentation has not been updated?

sloriot · 2021-09-02T08:30:12Z

/force-build:v0

github-actions · 2021-09-02T08:35:01Z

There was an error while building the doc:
/home/runner/work/cgal/cgal/Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt:108: warning: Found unknown command `subsubsubsection'

KaimoHu · 2021-09-02T12:35:53Z

There was an error while building the doc:
/home/runner/work/cgal/cgal/Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt:108: warning: Found unknown command `subsubsubsection'

Fixed the problem of "found unknown command `subsubsubsection'".

sloriot · 2021-09-02T12:36:44Z

/force-build:v0

afabri · 2021-09-02T12:39:39Z

As @maxGimeno pointed out to me, and I agree with him, the doc building command should only be called once a local build with doxygen was succesful. It is more to have the html output directly on github.

github-actions · 2021-09-02T12:40:30Z

The documentation is built. It will be available, after a few minutes, here : https://cgal.github.io/5939/v0/Manual/index.html

KaimoHu and others added 10 commits August 28, 2021 16:46

rebased Surface_mesh_minimal_angle_remeshing-KaimoHu from cgal/master

78a7f6d

generated the minimal_angle_remeshing.h in license

4ed88e2

Modified the head files of minimal_angle_remeshing related .h files

ecfbd17

renamed the file Bvd.h to bvd.h

bca4576

deleted the Bvd.h and Polygon_kernel.h

cabc721

Added the two files bvd.h and polygon_kernel.h

00cff6d

modified the local include directives to global iinclude directives

a62b44b

fixed the checking header errors

a09c63a

resolved the conflicts of parameters_interface.h

846e606

Merge branch 'master' into Surface_mesh_minimal_angle_remeshing-KaimoHu

7cf2a92

KaimoHu mentioned this pull request Aug 30, 2021

Surface mesh minimal angle remeshing kaimo hu #5919

Closed

modified the parameters_interface.h

288454c

sloriot added Not yet approved The feature or pull-request has not yet been approved. Pkg::PMP Small feature labels Aug 30, 2021

updated the user manual

8aae9fb

fixed the error when building the doc.

c39febb

update bibtex ref

2404104

KaimoHu added 2 commits August 31, 2021 20:07

improved the minimal angle remeshing section of the user manual

872796b

improved the size of the minimal_angle_remeshing.png in the user manu…

c5e4ab6

…al of PMP

modified the Polygon_mesh_processing.txt

5616545

sloriot added this to the 5.5-beta1 milestone Sep 23, 2021

update cmake for compiling the minimal area remeshing

9a2b044

MaelRL changed the title ~~rebased Surface_mesh_minimal_angle_remeshing-KaimoHu from cgal/master~~ Minimal angle remeshing Nov 22, 2021

MaelRL modified the milestones: 5.5-beta, 5.6-beta Mar 28, 2022

MaelRL modified the milestones: 5.6-beta, 5.7-beta Mar 23, 2023

janetournois modified the milestones: 6.0-beta, 6.1-beta May 16, 2024

MaelRL modified the milestones: 6.1-beta, 6.2-beta Mar 17, 2025

sloriot changed the base branch from master to main September 16, 2025 19:21

MaelRL modified the milestones: 6.2-beta, 6.3-beta Mar 18, 2026

Conversation

KaimoHu commented Aug 28, 2021

Summary of Changes

Release Management

Uh oh!

sloriot commented Aug 30, 2021

Uh oh!

KaimoHu commented Aug 31, 2021

Uh oh!

sloriot commented Aug 31, 2021

Uh oh!

github-actions bot commented Aug 31, 2021

Uh oh!

sloriot commented Aug 31, 2021

Uh oh!

github-actions bot commented Aug 31, 2021

Uh oh!

KaimoHu commented Aug 31, 2021

Uh oh!

sloriot commented Aug 31, 2021

Uh oh!

github-actions bot commented Aug 31, 2021

Uh oh!

KaimoHu commented Aug 31, 2021

Uh oh!

sloriot commented Sep 1, 2021

Uh oh!

KaimoHu commented Sep 2, 2021

Uh oh!

sloriot commented Sep 2, 2021

Uh oh!

github-actions bot commented Sep 2, 2021

Uh oh!

KaimoHu commented Sep 2, 2021

Uh oh!

sloriot commented Sep 2, 2021

Uh oh!

afabri commented Sep 2, 2021

Uh oh!

github-actions bot commented Sep 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants