TDS_3: use indices, and keep backward compatibility with handles #8909
+4,294
−1,382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terator are generic enough
This reverts commit abacbe7.
- one for storage (compact container...) - and a second one with generic function independent of the storage implementation
…dles-GF' into pr/afabri/8909-1
…dles-GF' into pr/afabri/8909-1
.. in case one would want to use it.
lrineau
force-pushed
the
Triangulation_3-Handles-GF
branch
from
dfd2d57 to
030b463
Compare
2 tasks
TODO: - regular - add a real test
Now done: - a mixing class template, - delaunay_3, - regular_3. TODO: - a real test A lot of tests pass: ``` 100% tests passed, 0 tests failed out of 435 Label Time Summary: CGAL_build_system = 1.62 sec*proc (2 tests) Installation = 1.62 sec*proc (2 tests) Point_set_3_Examples = 11.48 sec*proc (16 tests) Point_set_3_Tests = 6.82 sec*proc (10 tests) Polygon_mesh_processing_Examples = 811.57 sec*proc (142 tests) Polygon_mesh_processing_Tests = 966.71 sec*proc (148 tests) Surface_mesher_Examples = 77.76 sec*proc (6 tests) Surface_mesher_Tests = 97.27 sec*proc (10 tests) TDS_3_Examples = 26.27 sec*proc (8 tests) TDS_3_Tests = 19.63 sec*proc (6 tests) Triangulation_3_Demo = 27.23 sec*proc (1 test) Triangulation_3_Examples = 451.51 sec*proc (42 tests) Triangulation_3_Tests = 628.44 sec*proc (44 tests) Total Test time (real) = 421.98 sec ```
lrineau
changed the title
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Instead of changing the API of TDS, Triangulation, and everything using it, this PR takes another approach:
We store indices in the data structures instead of handles, and generate the handles on the fly, which hold a pointer to the TDS and an index.
We also split
Triangulation_data_structure_3in two: A base class which knows about storage and index/vs pointer and provides an API with handles. And a derived class that uses this API with handles, which works for both base classes as in the derived class we do not use pointers or indices directly.We checked that the Triangulation with indexed storage can be used in Alpha Wrapping without as only change of code the
typedefof theTDS.Todo
See tracking issue #8969.
Release Management