Replace deprecated random_shuffle with std::shuffle in Min_ellipse_2.h #9207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Replaced the deprecated
CGAL::cpp98::random_shufflewith the modern C++11std::shuffleinBounding_volumes/include/CGAL/Min_ellipse_2.h.To enable this change, I:
#include <random>.std::default_random_engineusing the seed from the existingCGAL::Randomobject to ensure thestd::shufflefunction works correctly with the existing random number generator logic.test_Min_ellipse_2test executable.Release Management