Skip to content

Conversation

@LOTUS9679
Copy link
Contributor

Summary of Changes

Replaced the deprecated CGAL::cpp98::random_shuffle with the modern C++11 std::shuffle in Bounding_volumes/include/CGAL/Min_ellipse_2.h.

To enable this change, I:

  • Added #include <random>.
  • Initialized a std::default_random_engine using the seed from the existing CGAL::Random object to ensure the std::shuffle function works correctly with the existing random number generator logic.
  • Verified the fix by building and running the test_Min_ellipse_2 test executable.

Release Management

  • Affected package(s): Bounding_volumes
  • Issue(s) solved (if any):
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature):
  • License and copyright ownership: I confirm that I have the right to contribute this code.

@albert-github
Copy link
Contributor

albert-github commented Dec 22, 2025

Looks like this proposed pull request not only contains a fix regarding random_shuffle but also (part of) the fix #9199 this should not be the case.

@LOTUS9679
Copy link
Contributor Author

@albert-github Thank you for the guidance! I have performed a rebase and force-push to clean up the history. This PR now contains only the random_shuffle fix and no unrelated commits.

@MaelRL
Copy link
Member

MaelRL commented Jan 6, 2026

See #9214 (comment).

@MaelRL MaelRL closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants